Commit 0c927b52 authored by Andrew Grieve's avatar Andrew Grieve Committed by Commit Bot

SuperSize: Fix requiresAuthentication() when query string is not escaped

E.g. chromium-binary-size-trybot-results%2Fandroid-binary-size
 vs: chromium-binary-size-trybot-results/android-binary-size

Bug: 1131568
Change-Id: I8801d04748d0d21bb4bdf2a63a56f78445a23160
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503634
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarMohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821453}
parent 16cc2bde
...@@ -39,8 +39,9 @@ function setSigninStatus() { ...@@ -39,8 +39,9 @@ function setSigninStatus() {
function requiresAuthentication() { function requiresAuthentication() {
// Assume everything requires auth except public trybot and one-offs. // Assume everything requires auth except public trybot and one-offs.
const isPublicTrybot = window.location.search.indexOf( const queryString = decodeURIComponent(location.search);
'chromium-binary-size-trybot-results%2Fandroid-binary-size') != -1; const isPublicTrybot = queryString.indexOf(
const isOneOff = window.location.search.indexOf('%2Foneoffs%2F') != -1; 'chromium-binary-size-trybot-results/android-binary-size') != -1;
const isOneOff = queryString.indexOf('/oneoffs/') != -1;
return !isPublicTrybot && !isOneOff; return !isPublicTrybot && !isOneOff;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment