Commit 0c947fb4 authored by Yutaka Hirano's avatar Yutaka Hirano Committed by Commit Bot

Remove the only tracing event in platform

platform/probe has only one tracing event: "PlatformResourceSendRequest"
which is called in ResourceFetcher::StartLoad. This is very similar to
what we are doing for "ResourceSendRequest" in
InspectorTraceEvent::WillSendRequest also called in
ResourceFetcher::StartLoad through
ResourceLoadObserver::WillSendRequest.

As the event has never been actually used, let's remove it.

This CL will allow us to remove PlatformProbeSink.

Bug: 914739
Change-Id: I0f93e363214ac6da071ee480ee155d3492fb3e7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616839
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: default avatarAlexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662507}
parent 87b0db79
...@@ -12,22 +12,12 @@ namespace blink { ...@@ -12,22 +12,12 @@ namespace blink {
namespace { namespace {
std::unique_ptr<TracedValue> BuildData(
const probe::PlatformSendRequest& probe) {
auto value = std::make_unique<TracedValue>();
value->SetString("id", String::Number(probe.identifier));
return value;
}
} // namespace } // namespace
void PlatformTraceEventsAgent::Will(const probe::PlatformSendRequest& probe) { void PlatformTraceEventsAgent::Will(const probe::PlatformSendRequest& probe) {
TRACE_EVENT_BEGIN1("devtools.timeline", "PlatformResourceSendRequest", "data",
BuildData(probe));
} }
void PlatformTraceEventsAgent::Did(const probe::PlatformSendRequest& probe) { void PlatformTraceEventsAgent::Did(const probe::PlatformSendRequest& probe) {
TRACE_EVENT_END0("devtools.timeline", "PlatformResourceSendRequest");
} }
} // namespace blink } // namespace blink
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment