Commit 0cbaa909 authored by haraken@chromium.org's avatar haraken@chromium.org

Oilpan: Reduce FIXME(OILPAN) from the code base

This CL removes FIXME(OILPAN) that is out-dated or doesn't make much sense.

BUG=

Review URL: https://codereview.chromium.org/1327793002

git-svn-id: svn://svn.chromium.org/blink/trunk@201639 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 94a143fc
...@@ -62,11 +62,7 @@ public: ...@@ -62,11 +62,7 @@ public:
} }
private: private:
// FIXME: Oilpan: RuleData is in the oilpan heap and this pointer RawPtrWillBeMember<const RuleData> m_ruleData;
// really should be traced. However, RuleData objects are
// allocated inside larger TerminatedArray objects and we cannot
// trace a raw rule data pointer at this point.
const RuleData* m_ruleData;
unsigned m_specificity; unsigned m_specificity;
uint64_t m_position; uint64_t m_position;
RawPtrWillBeMember<const CSSStyleSheet> m_parentStyleSheet; RawPtrWillBeMember<const CSSStyleSheet> m_parentStyleSheet;
......
...@@ -48,10 +48,6 @@ public: ...@@ -48,10 +48,6 @@ public:
private: private:
#if ENABLE(OILPAN) #if ENABLE(OILPAN)
// FIXME: Oilpan: the LayoutObject hierarchy isn't on the heap, but
// the SVG property hierarchy is. And the two meet here, so keep a
// persistent reference to the SVG part object by way of a heap-allocated
// wrapper object.
Persistent<LinearGradientAttributesWrapper> m_attributesWrapper; Persistent<LinearGradientAttributesWrapper> m_attributesWrapper;
LinearGradientAttributes& mutableAttributes() { return m_attributesWrapper->attributes(); } LinearGradientAttributes& mutableAttributes() { return m_attributesWrapper->attributes(); }
......
...@@ -102,8 +102,7 @@ void SVGImageChromeClient::animationTimerFired(Timer<SVGImageChromeClient>*) ...@@ -102,8 +102,7 @@ void SVGImageChromeClient::animationTimerFired(Timer<SVGImageChromeClient>*)
// below, including this object and its timer. For code simplicity, the // below, including this object and its timer. For code simplicity, the
// object protection isn't made the conditional on Oilpan. // object protection isn't made the conditional on Oilpan.
// //
// FIXME: Oilpan: move this and other ChromeClients to the Oilpan heap // TODO(oilpan): move SVGImage to the Oilpan heap and remove this protection.
// to render this protection redundant.
RefPtr<SVGImage> protect(m_image); RefPtr<SVGImage> protect(m_image);
m_image->frameView()->page()->animator().serviceScriptedAnimations(monotonicallyIncreasingTime()); m_image->frameView()->page()->animator().serviceScriptedAnimations(monotonicallyIncreasingTime());
m_image->frameView()->updateAllLifecyclePhases(); m_image->frameView()->updateAllLifecyclePhases();
......
...@@ -574,11 +574,7 @@ void Heap::globalWeakProcessing(Visitor* visitor) ...@@ -574,11 +574,7 @@ void Heap::globalWeakProcessing(Visitor* visitor)
void Heap::collectAllGarbage() void Heap::collectAllGarbage()
{ {
// FIXME: Oilpan: we should perform a single GC and everything // We need to run multiple GCs to collect a chain of persistent handles.
// should die. Unfortunately it is not the case for all objects
// because the hierarchy was not completely moved to the heap and
// some heap allocated objects own objects that contain persistents
// pointing to other heap allocated objects.
size_t previousLiveObjects = 0; size_t previousLiveObjects = 0;
for (int i = 0; i < 5; ++i) { for (int i = 0; i < 5; ++i) {
collectGarbage(ThreadState::NoHeapPointersOnStack, ThreadState::GCWithSweep, ForcedGC); collectGarbage(ThreadState::NoHeapPointersOnStack, ThreadState::GCWithSweep, ForcedGC);
......
...@@ -75,7 +75,6 @@ public: ...@@ -75,7 +75,6 @@ public:
T* get() const { return m_ptr; } T* get() const { return m_ptr; }
void clear() { m_ptr = 0; } void clear() { m_ptr = 0; }
// FIXME: oilpan: Remove release and leakRef once we remove RefPtrWillBeRawPtr.
RawPtr<T> release() RawPtr<T> release()
{ {
RawPtr<T> tmp = m_ptr; RawPtr<T> tmp = m_ptr;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment