Commit 0cc8f08b authored by dpranke's avatar dpranke Committed by Commit bot

Fix a dependency issue w/ gn refs for android apks.

One of the intermediate steps in the build process for
creating Android APKs depends on the output from another
intermediate step, but that dependency was not *also* declared
in the 'deps' target in the GN build file.

As a result, 'gn refs' (and hence 'mb analyze') would not calculate
the right set of dependencies and we would incorrectly conclude that
no compiles were necessary in cases where they really were needed.

More details in the bug.

R=cjhopman@chromium.org, brettw@chromium.org
BUG=487897

Review URL: https://codereview.chromium.org/1129773004

Cr-Commit-Position: refs/heads/master@{#330152}
parent 294cf473
...@@ -616,6 +616,7 @@ template("create_apk") { ...@@ -616,6 +616,7 @@ template("create_apk") {
group(target_name) { group(target_name) {
deps = [ deps = [
":${target_name}__finalize", ":${target_name}__finalize",
":${target_name}__package_resources",
] ]
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment