Commit 0cf6393f authored by Xida Chen's avatar Xida Chen Committed by Commit Bot

Disable DownloadExtensionTest_SearchPauseResumeCancelGetFileIconIncognito on Win

TBR=wjmaclean@chromium.org
NOTRY=true

Bug: 874946
Change-Id: I21c44dc3e423f28012eb0459b1b1302bfcf47b3f
Reviewed-on: https://chromium-review.googlesource.com/1178106Reviewed-by: default avatarXida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583688}
parent 71d6c062
...@@ -1496,12 +1496,21 @@ IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, ...@@ -1496,12 +1496,21 @@ IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,
ASSERT_EQ(items[2]->GetTargetFilePath().value(), item_name); ASSERT_EQ(items[2]->GetTargetFilePath().value(), item_name);
} }
// https://crbug.com/874946, flaky on Win.
#if defined(OS_WIN)
#define MAYBE_DownloadExtensionTest_SearchPauseResumeCancelGetFileIconIncognito \
DISABLED_DownloadExtensionTest_SearchPauseResumeCancelGetFileIconIncognito
#else
#define MAYBE_DownloadExtensionTest_SearchPauseResumeCancelGetFileIconIncognito \
DownloadExtensionTest_SearchPauseResumeCancelGetFileIconIncognito
#endif
// Test that incognito downloads are only visible in incognito contexts, and // Test that incognito downloads are only visible in incognito contexts, and
// test that on-record downloads are visible in both incognito and on-record // test that on-record downloads are visible in both incognito and on-record
// contexts, for DownloadsSearchFunction, DownloadsPauseFunction, // contexts, for DownloadsSearchFunction, DownloadsPauseFunction,
// DownloadsResumeFunction, and DownloadsCancelFunction. // DownloadsResumeFunction, and DownloadsCancelFunction.
IN_PROC_BROWSER_TEST_F(DownloadExtensionTest, IN_PROC_BROWSER_TEST_F(
DownloadExtensionTest_SearchPauseResumeCancelGetFileIconIncognito) { DownloadExtensionTest,
MAYBE_DownloadExtensionTest_SearchPauseResumeCancelGetFileIconIncognito) {
std::unique_ptr<base::Value> result_value; std::unique_ptr<base::Value> result_value;
base::ListValue* result_list = NULL; base::ListValue* result_list = NULL;
base::DictionaryValue* result_dict = NULL; base::DictionaryValue* result_dict = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment