Commit 0d08508e authored by Kenneth Russell's avatar Kenneth Russell Committed by Commit Bot

Reland "Reenable GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash"

This reverts commit a337f08f.

Reason for revert: this CL only re-enables the test on Windows; the
failure seen was on macOS, which is a different platform and had a
preexisting flaky expectation for this test. Investigation will
continue on the bug into the flakiness on that platform.

Original change's description:
> Revert "Reenable GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash"
> 
> This reverts commit 8bd7e583.
> 
> Reason for revert: Still flaky :( https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/166516
> 
> Original change's description:
> > Reenable GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash
> > 
> > This was flaky, but should be fixed.
> > 
> > Bug: 878258
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> > Change-Id: I3e037e41339ddff9d46ec0a7ca7679064a3322e0
> > Reviewed-on: https://chromium-review.googlesource.com/c/1285526
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Commit-Queue: enne <enne@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600813}
> 
> TBR=kbr@chromium.org,enne@chromium.org
> 
> Change-Id: I0dd172bd7db86982f9b1bf49e2a57c059958d348
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 878258
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/c/1290950
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: Christian Dullweber <dullweber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601098}

TBR=kbr@chromium.org,enne@chromium.org,dullweber@chromium.org

Change-Id: If1ca9d7ae9ef2122150edfa9d965e0a9cd5c442a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878258
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1292431Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601268}
parent 753cc316
...@@ -68,7 +68,3 @@ class ContextLostExpectations(GpuTestExpectations): ...@@ -68,7 +68,3 @@ class ContextLostExpectations(GpuTestExpectations):
['android', ('qualcomm', 'Adreno (TM) 420')], bug=611906) ['android', ('qualcomm', 'Adreno (TM) 420')], bug=611906)
self.Fail('ContextLost_WebGLContextLostFromQuantity', self.Fail('ContextLost_WebGLContextLostFromQuantity',
['android', ('qualcomm', 'Adreno (TM) 420')], bug=611906) ['android', ('qualcomm', 'Adreno (TM) 420')], bug=611906)
# Temporary until Ganesh fix is made. Too flaky to mark as flaky.
self.Fail('GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash',
['win'], bug=878258)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment