[ios] Remove stale includes/dependencies on //components/signin/core/browser

As part of the servicification project and the migration to the Identity
service, we have removed dependencies on //components/signin/core/browser
from many places, but some stale includes and dependencies remained.

This patch attempts to clean that up so that we have a better and cleaner
surface to work upon when doing the servicification.

Bug: 903846
Change-Id: I1f28f1c08047c279dcad60cff4e66945d4e68852
Reviewed-on: https://chromium-review.googlesource.com/c/1329923Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#607119}

ios/chrome/browser/autofill/BUILD.gn

@@ -57,7 +57,6 @@ source_set("autofill") {
     "//components/keyed_service/core",
     "//components/keyed_service/ios",
     "//components/prefs",
-    "//components/signin/core/browser",
     "//ios/chrome/app/strings",
     "//ios/chrome/browser",
     "//ios/chrome/browser/browser_state",

ios/chrome/browser/autofill/personal_data_manager_factory.cc

@@ -11,7 +11,6 @@
 #include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
 #include "components/keyed_service/core/service_access_type.h"
 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "ios/chrome/browser/application_context.h"
 #include "ios/chrome/browser/autofill/autofill_profile_validator_factory.h"
 #include "ios/chrome/browser/browser_state/browser_state_otr_helper.h"

ios/chrome/browser/gcm/BUILD.gn

@@ -11,7 +11,6 @@ source_set("gcm") {
     "//base",
     "//components/gcm_driver",
     "//components/keyed_service/ios",
-    "//components/signin/core/browser",
     "//ios/chrome/browser",
     "//ios/chrome/browser/browser_state",
     "//ios/chrome/browser/signin",

ios/chrome/browser/gcm/ios_chrome_gcm_profile_service_factory.cc

@@ -12,7 +12,6 @@
 #include "components/gcm_driver/gcm_client_factory.h"
 #include "components/gcm_driver/gcm_profile_service.h"
 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "ios/chrome/browser/application_context.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/signin/identity_manager_factory.h"

ios/chrome/browser/history/BUILD.gn

@@ -28,7 +28,6 @@ source_set("history") {
     "//components/keyed_service/ios",
     "//components/pref_registry",
     "//components/prefs",
-    "//components/signin/core/browser",
     "//components/sync",
     "//ios/chrome/browser",
     "//ios/chrome/browser/browser_state",

ios/chrome/browser/history/web_history_service_factory.cc

@@ -9,8 +9,6 @@
 #include "components/history/core/browser/web_history_service.h"
 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
 #include "components/prefs/pref_service.h"
-#include "components/signin/core/browser/profile_oauth2_token_service.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "components/sync/driver/sync_service.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/signin/identity_manager_factory.h"

ios/chrome/browser/invalidation/BUILD.gn

@@ -18,7 +18,6 @@ source_set("invalidation") {
     "//components/keyed_service/ios",
     "//components/pref_registry",
     "//components/prefs",
-    "//components/signin/core/browser",
     "//ios/chrome/browser",
     "//ios/chrome/browser/browser_state",
     "//ios/chrome/browser/gcm",

ios/chrome/browser/invalidation/ios_chrome_deprecated_profile_invalidation_provider_factory.mm

@@ -18,7 +18,6 @@
 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_registry.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "ios/chrome/browser/application_context.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/gcm/ios_chrome_gcm_profile_service_factory.h"

ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.mm

@@ -19,7 +19,6 @@
 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_registry.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "ios/chrome/browser/application_context.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/gcm/instance_id/ios_chrome_instance_id_profile_service_factory.h"

ios/chrome/browser/sync/BUILD.gn

@@ -103,7 +103,6 @@ source_set("test_support") {
     "//components/browser_sync:test_support",
     "//components/keyed_service/core",
     "//components/keyed_service/ios",
-    "//components/signin/core/browser",
     "//components/sync",
     "//components/sync:test_support_driver",
     "//ios/chrome/browser/browser_state",

ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc

@@ -11,7 +11,6 @@
 #include "base/bind_helpers.h"
 #include "components/browser_sync/profile_sync_service_mock.h"
 #include "components/browser_sync/profile_sync_test_util.h"
-#include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/signin/identity_manager_factory.h"
 #include "ios/chrome/browser/sync/ios_chrome_sync_client.h"

ios/chrome/browser/sync/profile_sync_service_factory.cc

@@ -15,7 +15,6 @@
 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
 #include "components/network_time/network_time_tracker.h"
 #include "components/signin/core/browser/device_id_helper.h"
-#include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "components/sync/driver/startup_controller.h"
 #include "components/sync/driver/sync_util.h"
 #include "components/unified_consent/feature.h"

ios/chrome/browser/ui/first_run/BUILD.gn

@@ -92,7 +92,6 @@ source_set("eg_tests") {
     "//base/test:test_support",
     "//components/metrics",
     "//components/prefs",
-    "//components/signin/core/browser",
     "//ios/chrome/app:app_internal",
     "//ios/chrome/app/strings",
     "//ios/chrome/browser",

ios/chrome/browser/ui/first_run/first_run_egtest.mm

@@ -11,13 +11,11 @@
 #include "components/metrics/metrics_reporting_default_state.h"
 #include "components/prefs/pref_member.h"
 #include "components/prefs/pref_service.h"
-#include "components/signin/core/browser/signin_manager.h"
 #import "ios/chrome/app/main_controller.h"
 #include "ios/chrome/browser/application_context.h"
 #import "ios/chrome/browser/geolocation/omnibox_geolocation_controller+Testing.h"
 #import "ios/chrome/browser/geolocation/omnibox_geolocation_controller.h"
 #import "ios/chrome/browser/geolocation/test_location_manager.h"
-#include "ios/chrome/browser/signin/signin_manager_factory.h"
 #include "ios/chrome/browser/sync/sync_setup_service.h"
 #include "ios/chrome/browser/sync/sync_setup_service_factory.h"
 #import "ios/chrome/browser/ui/authentication/signin_earlgrey_utils.h"

ios/chrome/browser/ui/settings/BUILD.gn

@@ -398,7 +398,6 @@ source_set("eg_tests") {
     "//components/password_manager/core/common",
     "//components/prefs",
     "//components/search_engines",
-    "//components/signin/core/browser",
     "//components/strings",
     "//ios/chrome/app:app_internal",
     "//ios/chrome/app/strings",

ios/chrome/browser/ui/settings/accounts_collection_egtest.mm

@@ -7,7 +7,6 @@
 
 #include "base/strings/sys_string_conversions.h"
 #include "components/browser_sync/profile_sync_service.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "components/strings/grit/components_strings.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/experimental_flags.h"
@@ -15,7 +14,6 @@
 #include "ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.h"
 #import "ios/chrome/browser/signin/authentication_service.h"
 #import "ios/chrome/browser/signin/authentication_service_factory.h"
-#include "ios/chrome/browser/signin/signin_manager_factory.h"
 #include "ios/chrome/browser/sync/profile_sync_service_factory.h"
 #import "ios/chrome/browser/ui/authentication/account_control_item.h"
 #import "ios/chrome/browser/ui/authentication/signin_earl_grey_ui.h"

ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm

@@ -11,7 +11,6 @@
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/signin/core/browser/account_tracker_service.h"
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
-#include "components/signin/core/browser/signin_manager.h"
 #import "components/signin/ios/browser/oauth2_token_service_observer_bridge.h"
 #include "components/strings/grit/components_strings.h"
 #include "components/unified_consent/feature.h"

ios/chrome/browser/ui/settings/signin_settings_egtest.mm

@@ -6,11 +6,8 @@
 
 #include "base/strings/sys_string_conversions.h"
 #include "components/prefs/pref_service.h"
-#include "components/signin/core/browser/account_info.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/pref_names.h"
-#include "ios/chrome/browser/signin/signin_manager_factory.h"
 #import "ios/chrome/browser/ui/authentication/signin_earl_grey_ui.h"
 #import "ios/chrome/browser/ui/authentication/signin_earlgrey_utils.h"
 #import "ios/chrome/browser/ui/settings/settings_collection_view_controller.h"

ios/chrome/browser/ui/signin_interaction/BUILD.gn

@@ -38,7 +38,6 @@ source_set("eg_tests") {
   deps = [
     "//base",
     "//base/test:test_support",
-    "//components/signin/core/browser",
     "//ios/chrome/app/strings",
     "//ios/chrome/browser",
     "//ios/chrome/browser/signin",

ios/chrome/browser/ui/signin_interaction/signin_interaction_controller_egtest.mm

@@ -8,9 +8,7 @@
 #include "base/strings/sys_string_conversions.h"
 #import "base/test/ios/wait_util.h"
 #include "base/test/scoped_feature_list.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "ios/chrome/browser/experimental_flags.h"
-#include "ios/chrome/browser/signin/signin_manager_factory.h"
 #import "ios/chrome/browser/ui/authentication/signin_earl_grey_ui.h"
 #import "ios/chrome/browser/ui/authentication/signin_earlgrey_utils.h"
 #import "ios/chrome/browser/ui/authentication/signin_promo_view.h"

ios/web_view/internal/autofill/web_view_personal_data_manager_factory.cc

@@ -11,7 +11,6 @@
 #include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
 #include "components/keyed_service/core/service_access_type.h"
 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "ios/web_view/internal/app/application_context.h"
 #include "ios/web_view/internal/signin/web_view_identity_manager_factory.h"
 #include "ios/web_view/internal/web_view_browser_state.h"

ios/web_view/internal/signin/web_view_identity_manager_factory.mm

@@ -8,7 +8,6 @@
 
 #include "components/keyed_service/core/keyed_service.h"
 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "ios/web_view/internal/signin/web_view_account_tracker_service_factory.h"
 #include "ios/web_view/internal/signin/web_view_gaia_cookie_manager_service_factory.h"
 #include "ios/web_view/internal/signin/web_view_oauth2_token_service_factory.h"

ios/web_view/internal/sync/web_view_profile_invalidation_provider_factory.mm

@@ -18,7 +18,6 @@
 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_registry.h"
-#include "components/signin/core/browser/signin_manager.h"
 #include "ios/web/public/web_client.h"
 #include "ios/web_view/internal/app/application_context.h"
 #include "ios/web_view/internal/signin/web_view_identity_manager_factory.h"