Commit 0d39b9f8 authored by Hitoshi Yoshida's avatar Hitoshi Yoshida Committed by Commit Bot

bindings: Add dependencies on generated files

Code in Blink depends on some generated code in general.
And its dependencies can be indirect.  For example,
  t/b/r/bindings/modules/v8/properties_per_feature_installer_for_testing.cc
includes
  t/b/r/bindings/core/v8/v8_origin_trials_test_dictionary.h
through some other header files.  But they have no dependency chain
in GN file, and thus flaky compile errors can happen.

This CL adds dependencies to connect a target to compile the .cc file
and a target to generate the .h file.


Bug: 1138802
Change-Id: I1f535475ffaaaa0373330dc66dc3ed3951a571e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477053Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Auto-Submit: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819731}
parent c8327b2e
......@@ -75,8 +75,10 @@ group("generated") {
"//third_party/blink/renderer/core/*",
]
public_deps =
[ "//third_party/blink/renderer/bindings:generate_bindings_all" ]
public_deps = [
":bindings_core_v8_generated",
"//third_party/blink/renderer/bindings:generate_bindings_all",
]
}
if (use_blink_v8_binding_new_idl_interface) {
......
......@@ -77,8 +77,10 @@ group("generated") {
"//third_party/blink/renderer/modules/*",
]
public_deps =
[ "//third_party/blink/renderer/bindings:generate_bindings_all" ]
public_deps = [
":bindings_modules_v8_generated",
"//third_party/blink/renderer/bindings:generate_bindings_all",
]
}
group("bindings_modules_v8_generated") {
......@@ -89,6 +91,7 @@ group("bindings_modules_v8_generated") {
":generate_bindings_modules_v8_partial_interfaces",
":generate_bindings_modules_v8_partial_interfaces_for_testing",
":generate_v8_context_snapshot_external_references",
"//third_party/blink/renderer/bindings/core/v8:bindings_core_v8_generated",
]
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment