Commit 0d46f955 authored by Jinsong Fan's avatar Jinsong Fan Committed by Commit Bot

Remove unimplemented methods from browser_process_impl.h

browser_process_impl.h contains declarations for CreateStatusTrayManager(),
CreateSafeBrowsingDetectionService() and CreateViewedPageTracker() methods,
whose implementations have since been removed. This CL removes these unused
declarations and add check for private field created_notification_ui_manager_.

Bug:

Change-Id: If9337bae7a5fc20a5fcc1a98c42e53e803102660
Reviewed-on: https://chromium-review.googlesource.com/892685
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533334}
parent 4ac95514
...@@ -174,16 +174,13 @@ class BrowserProcessImpl : public BrowserProcess, ...@@ -174,16 +174,13 @@ class BrowserProcessImpl : public BrowserProcess,
void CreateWatchdogThread(); void CreateWatchdogThread();
void CreateProfileManager(); void CreateProfileManager();
void CreateLocalState(); void CreateLocalState();
void CreateViewedPageTracker();
void CreateIconManager(); void CreateIconManager();
void CreateIntranetRedirectDetector(); void CreateIntranetRedirectDetector();
void CreateNotificationPlatformBridge(); void CreateNotificationPlatformBridge();
void CreateNotificationUIManager(); void CreateNotificationUIManager();
void CreateStatusTrayManager();
void CreatePrintPreviewDialogController(); void CreatePrintPreviewDialogController();
void CreateBackgroundPrintingManager(); void CreateBackgroundPrintingManager();
void CreateSafeBrowsingService(); void CreateSafeBrowsingService();
void CreateSafeBrowsingDetectionService();
void CreateSubresourceFilterRulesetService(); void CreateSubresourceFilterRulesetService();
void CreateOptimizationGuideService(); void CreateOptimizationGuideService();
void CreateStatusTray(); void CreateStatusTray();
...@@ -259,9 +256,11 @@ class BrowserProcessImpl : public BrowserProcess, ...@@ -259,9 +256,11 @@ class BrowserProcessImpl : public BrowserProcess,
background_printing_manager_; background_printing_manager_;
#endif #endif
#if !defined(OS_ANDROID)
// Manager for desktop notification UI. // Manager for desktop notification UI.
bool created_notification_ui_manager_ = false; bool created_notification_ui_manager_ = false;
std::unique_ptr<NotificationUIManager> notification_ui_manager_; std::unique_ptr<NotificationUIManager> notification_ui_manager_;
#endif
std::unique_ptr<IntranetRedirectDetector> intranet_redirect_detector_; std::unique_ptr<IntranetRedirectDetector> intranet_redirect_detector_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment