[cros] Remove NOTREACHED() in GetHomeDir() since there will be callers that...

[cros] Remove NOTREACHED() in GetHomeDir() since there will be callers that access HomeDir at least once prior to user sign in.

Most callers are now using PathService::Get(base::DIR_HOME) which caches the
value of GetHomeDir() if it has been called prior to user sign in.

With a current implementation it is a possible use of API and should not
crash debug builds.

BUG=331530

Review URL: https://codereview.chromium.org/310033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274620 0039d316-1c4b-4281-b951-d872f2087c98

base/file_util_posix.cc

@@ -459,9 +459,8 @@ bool GetTempDir(FilePath* path) {
 FilePath GetHomeDir() {
 #if defined(OS_CHROMEOS)
   if (SysInfo::IsRunningOnChromeOS()) {
-    // On Chrome OS chrome::DIR_USER_DATA is overriden with a primary user
-    // homedir once it becomes available.
-    NOTREACHED() << "Called GetHomeDir() without base::DIR_HOME override";
+    // On Chrome OS chrome::DIR_USER_DATA is overridden with a primary user
+    // homedir once it becomes available. Return / as the safe option.
     return FilePath("/");
   }
 #endif