Add policy checks to SmbShare UI.

If the policy for NetworkFileSharesAllowed is set to false, users will
not be able to mount shares nor will the be able to access the mount ui


Bug: chromium:757625
Change-Id: Ief64c9a9c3c2a574b931bc3f21516d471c26bcd4
Reviewed-on: https://chromium-review.googlesource.com/1152490Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584443}

chrome/browser/extensions/api/settings_private/prefs_util.cc

@@ -179,6 +179,10 @@ const PrefsUtil::TypedPrefMap& PrefsUtil::GetWhitelistedKeys() {
       settings_api::PrefType::PREF_TYPE_BOOLEAN;
   (*s_whitelist)[drive::prefs::kDisableDrive] =
       settings_api::PrefType::PREF_TYPE_BOOLEAN;
+#if defined(OS_CHROMEOS)
+  (*s_whitelist)[::prefs::kNetworkFileSharesAllowed] =
+      settings_api::PrefType::PREF_TYPE_BOOLEAN;
+#endif
 
   // Printing settings.
   (*s_whitelist)[::prefs::kLocalDiscoveryNotificationsEnabled] =

chrome/browser/resources/settings/downloads_page/downloads_page.html

@@ -81,7 +81,7 @@
       <settings-subpage
           associated-control="[[$$('#smbShares')]]"
           page-title="$i18n{smbSharesTitle}">
-        <settings-smb-shares-page>
+        <settings-smb-shares-page prefs="[[prefs]]">
         </settings-smb-shares-page>
       </settings-subpage>
     </template>

chrome/browser/resources/settings/downloads_page/smb_shares_page.html

@@ -24,8 +24,16 @@
           $i18n{requireNetworkMessage}
         </div>
       </div>
+      <template is="dom-if" if="[[!prefs.network_file_shares.allowed.value]]"
+          restamp>
+        <cr-policy-pref-indicator
+            pref="[[prefs.network_file_shares.allowed]]"
+            icon-aria-label="$i18n{smbSharesTitle}">
+        </cr-policy-pref-indicator>
+      </template>
       <paper-button class="action-button" id="addShare"
-          on-click="onAddShareTap_">
+          on-click="onAddShareTap_"
+          disabled="[[!prefs.network_file_shares.allowed.value]]">
         $i18n{addSmbShare}
       </paper-button>
     </div>

chrome/browser/resources/settings/downloads_page/smb_shares_page.js

@@ -8,6 +8,14 @@ Polymer({
   behaviors: [WebUIListenerBehavior],
 
   properties: {
+    /**
+     * Preferences state.
+     */
+    prefs: {
+      type: Object,
+      notify: true,
+    },
+
     /** @private */
     showAddSmbDialog_: Boolean,
 

chrome/test/data/webui/settings/smb_shares_page_tests.js

@@ -104,4 +104,18 @@ suite('AddSmbShareDialogTests', function() {
     return smbBrowserProxy.whenCalled('startDiscovery');
   });
 
+  test('ControlledByPolicy', function() {
+    const button = page.$$('#addShare');
+
+    assertFalse(!!page.$$('cr-policy-pref-indicator'));
+    expectFalse(button.disabled);
+
+    page.prefs = {
+      network_file_shares: {allowed: {value: false}},
+    };
+    Polymer.dom.flush();
+
+    assertTrue(!!page.$$('cr-policy-pref-indicator'));
+    assertTrue(button.disabled);
+  });
 });