Skip to content

GitLab

T
tangled
Commit 0d6a513b authored by tfarina@chromium.org's avatar tfarina@chromium.org
Browse files
Options

clang: Add missing 'virtual' keyword to some overridden functions. 

R=erg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10698147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146258 0039d316-1c4b-4281-b951-d872f2087c98
parent 901fd6ed
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 4 deletions
tools/clang/plugins/FindBadConstructs.cpp
View file @ 0d6a513b
...@@ -399,13 +399,15 @@ class FindBadConstructsAction : public PluginASTAction { ...@@ -399,13 +399,15 @@ class FindBadConstructsAction : public PluginASTAction {
} }
protected: protected:
ASTConsumer* CreateASTConsumer(CompilerInstance &CI, llvm::StringRef ref) { // Overridden from PluginASTAction:
virtual ASTConsumer* CreateASTConsumer(CompilerInstance& instance,
llvm::StringRef ref) {
return new FindBadConstructsConsumer( return new FindBadConstructsConsumer(
CI, check_refcounted_dtors_, check_virtuals_in_implementations_); instance, check_refcounted_dtors_, check_virtuals_in_implementations_);
} }
bool ParseArgs(const CompilerInstance &CI, virtual bool ParseArgs(const CompilerInstance& instance,
const std::vector<std::string>& args) { const std::vector<std::string>& args) {
bool parsed = true; bool parsed = true;
for (size_t i = 0; i < args.size() && parsed; ++i) { for (size_t i = 0; i < args.size() && parsed; ++i) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment