Commit 0d8c5c5b authored by Tien-Ren Chen's avatar Tien-Ren Chen Committed by Commit Bot

[Blink] Add CHECK for composited layers with nullptr properties

This CL is for debugging the root cause of https://crbug.com/856818 .
Instead of propagating the bad state and crash later, we will abort when
the bad state is assigned, in hope to collect more context from the
crash trace.

BUG=856818

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I41bfa2946396f157f72b79d867dc4717c926169a
Reviewed-on: https://chromium-review.googlesource.com/1168135Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582048}
parent 23b381af
...@@ -1005,6 +1005,9 @@ void GraphicsLayer::SetLayerState(const PropertyTreeState& layer_state, ...@@ -1005,6 +1005,9 @@ void GraphicsLayer::SetLayerState(const PropertyTreeState& layer_state,
} }
layer_state_->state = layer_state; layer_state_->state = layer_state;
layer_state_->offset = layer_offset; layer_state_->offset = layer_offset;
CHECK(layer_state_->state.Transform() && layer_state_->state.Clip() &&
layer_state_->state.Effect());
} }
void GraphicsLayer::SetContentsLayerState(const PropertyTreeState& layer_state, void GraphicsLayer::SetContentsLayerState(const PropertyTreeState& layer_state,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment