Early out from sheriff-o-matic loop.

Don't compute all the keys for a loop that we almost
always early out from. Also, the early out was wrong because
it was just returning from the anonymous function.

NOTRY=true

Review URL: https://codereview.chromium.org/557173002

git-svn-id: svn://svn.chromium.org/blink/trunk@181699 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/Tools/GardeningServer/model/ct-failure-group.html

@@ -45,16 +45,7 @@ CTFailureGroup.prototype.clearBug = function(bug) {
 };
 
 CTFailureGroup.prototype._failedOnce = function() {
-  var totalFailures = 0;
-  for (var i = 0; i < this.data.dataToExamine().length; i++) {
-    var resultNodes = this.data.dataToExamine()[i].resultNodesByBuilder;
-    Object.keys(resultNodes, function(r) {
-      totalFailures += resultNodes[r].failingBuildCount;
-      if (totalFailures > 1)
-        return false;
-    }.bind(this));
-  }
-  return totalFailures == 1;
+  return this.data.failedOnce && this.data.failedOnce();
 }
 
 CTFailureGroup.prototype._computeProperties = function() {

third_party/WebKit/Tools/GardeningServer/model/ct-sheriff-failure-group-data.html

@@ -28,4 +28,17 @@ CTSheriffFailureGroupData.prototype.failureKeys = function() {
     return failure.keys();
   }).flatten();
 };
+
+CTSheriffFailureGroupData.prototype.failedOnce = function() {
+  var totalFailures = 0;
+  for (var i = 0; i < this.failures.length; i++) {
+    var resultNodes = this.failures[i].resultNodesByBuilder;
+    for (var r in resultNodes) {
+      totalFailures += resultNodes[r].failingBuildCount;
+      if (totalFailures > 1)
+        return false;
+    }
+  }
+  return totalFailures == 1;
+}
 </script>