Commit 0d9c12c7 authored by Ian Barkley-Yeung's avatar Ian Barkley-Yeung Committed by Commit Bot

Fix os in JavaScript error reports

Fix 'os' metadata so that it is not hardcoded to "ChromeOS"

Bug: chromium:1121816

Change-Id: Iebdff3629d5e37b07c2ede2f298302d8f3908883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463098
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org>
Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: default avatarMiriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816372}
parent d8e5d153
...@@ -267,8 +267,12 @@ void OnConsentCheckCompleted( ...@@ -267,8 +267,12 @@ void OnConsentCheckCompleted(
params["browser"] = "Chrome"; params["browser"] = "Chrome";
params["browser_version"] = platform.version; params["browser_version"] = platform.version;
params["channel"] = platform.channel; params["channel"] = platform.channel;
// TODO(https://crbug.com/1121816): Handle non-ChromeOS platforms. #if defined(OS_CHROMEOS) || BUILDFLAG(IS_LACROS)
// base::SysInfo::OperatingSystemName() returns "Linux" on ChromeOS devices.
params["os"] = "ChromeOS"; params["os"] = "ChromeOS";
#else
params["os"] = base::SysInfo::OperatingSystemName();
#endif
params["os_version"] = platform.os_version; params["os_version"] = platform.os_version;
params["full_url"] = source.spec(); params["full_url"] = source.spec();
params["url"] = source.path(); params["url"] = source.path();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment