Commit 0da749a5 authored by Ankit Kumar 🌪️'s avatar Ankit Kumar 🌪️ Committed by Commit Bot

Fix nits in PDF accessibility code.

- Use EXPECT_* instead of ASSERT_* in unit tests.

Change-Id: I52e8d37102e01860ad7ae618501b925e41351c69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895269
Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Reviewed-by: default avatarKevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#718102}
parent a64486a8
......@@ -34,7 +34,7 @@ TEST(PdfAccessibilityTreeUnitTest, TextRunsAndCharsMismatch) {
ppapi::PdfAccessibilityPageObjects page_objects;
ASSERT_FALSE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
EXPECT_FALSE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
page_objects));
}
......@@ -50,7 +50,7 @@ TEST(PdfAccessibilityTreeUnitTest, TextRunsAndCharsMatch) {
ppapi::PdfAccessibilityPageObjects page_objects;
ASSERT_TRUE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
EXPECT_TRUE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
page_objects));
}
......@@ -80,7 +80,7 @@ TEST(PdfAccessibilityTreeUnitTest, UnsortedLinkVector) {
page_objects.links.push_back(std::move(link));
}
ASSERT_FALSE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
EXPECT_FALSE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
page_objects));
}
......@@ -101,7 +101,7 @@ TEST(PdfAccessibilityTreeUnitTest, OutOfBoundLink) {
page_objects.links.push_back(std::move(link));
}
ASSERT_FALSE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
EXPECT_FALSE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
page_objects));
}
......@@ -129,7 +129,7 @@ TEST(PdfAccessibilityTreeUnitTest, UnsortedImageVector) {
page_objects.images.push_back(std::move(image));
}
ASSERT_FALSE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
EXPECT_FALSE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
page_objects));
}
......@@ -149,7 +149,7 @@ TEST(PdfAccessibilityTreeUnitTest, OutOfBoundImage) {
page_objects.images.push_back(std::move(image));
}
ASSERT_FALSE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
EXPECT_FALSE(PdfAccessibilityTree::IsDataFromPluginValid(text_runs, chars,
page_objects));
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment