Commit 0db133f9 authored by Mike Dougherty's avatar Mike Dougherty Committed by Commit Bot

Re-enable testTappingKeyboardDismissCreditCardControllerPopOver

Using the EarlGrey or XCUITest helpers to type do not trigger software
keyboard pressed which are needed in order to dismiss the popover in
this test. Replace grey_typeText with grey_tap on an arbitrary keyboard
key to dismiss the credit card popover.

Fixed: 1099432
Change-Id: If23c886437b264893700b943b86039f9a31a8f5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303046
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: default avatarJavier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789402}
parent 80388365
...@@ -442,8 +442,7 @@ BOOL WaitForKeyboardToAppear() { ...@@ -442,8 +442,7 @@ BOOL WaitForKeyboardToAppear() {
// Tests that the credit card View Controller is dismissed when tapping the // Tests that the credit card View Controller is dismissed when tapping the
// keyboard. // keyboard.
// TODO(crbug.com/1099432): Test fails on iPad when rolling EG2 version. - (void)testTappingKeyboardDismissCreditCardControllerPopOver {
- (void)DISABLED_testTappingKeyboardDismissCreditCardControllerPopOver {
if (![ChromeEarlGrey isIPadIdiom]) { if (![ChromeEarlGrey isIPadIdiom]) {
return; return;
} }
...@@ -462,9 +461,10 @@ BOOL WaitForKeyboardToAppear() { ...@@ -462,9 +461,10 @@ BOOL WaitForKeyboardToAppear() {
selectElementWithMatcher:ManualFallbackCreditCardTableViewMatcher()] selectElementWithMatcher:ManualFallbackCreditCardTableViewMatcher()]
assertWithMatcher:grey_sufficientlyVisible()]; assertWithMatcher:grey_sufficientlyVisible()];
[[EarlGrey // Tap a keyboard key directly. Typing with EG helpers do not trigger physical
selectElementWithMatcher:[KeyboardAppInterface keyboardWindowMatcher]] // keyboard presses.
performAction:grey_typeText(@"text")]; [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(@"G")]
performAction:grey_tap()];
// Verify the credit card controller table view and the credit card icon is // Verify the credit card controller table view and the credit card icon is
// NOT visible. // NOT visible.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment