Commit 0dd092fa authored by hyatt@apple.com's avatar hyatt@apple.com

2009-04-29 David Hyatt <hyatt@apple.com>

        Reviewed by John Sullivan.

        Fix for <rdar://problem/6835573>, Find Banner turns invisible when WebView is resized.  Make sure
        not to resize the interior views of a WebView in response to its bounds changing when not using
        viewless WebKit.  Auto-resizing rules were already in place to handle size adjustments for us.
        Just mark as needing layout and do nothing else.

        This does mean viewless WebKit is broken with the Find Banner, and that will likely require a
        Safari change (using a new API that will enable clients to define the edges of the content area as offsets
        from the sides of the WebView).

        * WebView/WebView.mm:
        (-[WebView _boundsChanged]):



git-svn-id: svn://svn.chromium.org/blink/trunk@42999 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 45869a2d
2009-04-29 David Hyatt <hyatt@apple.com>
Reviewed by John Sullivan.
Fix for <rdar://problem/6835573>, Find Banner turns invisible when WebView is resized. Make sure
not to resize the interior views of a WebView in response to its bounds changing when not using
viewless WebKit. Auto-resizing rules were already in place to handle size adjustments for us.
Just mark as needing layout and do nothing else.
This does mean viewless WebKit is broken with the Find Banner, and that will likely require a
Safari change (using a new API that will enable clients to define the edges of the content area as offsets
from the sides of the WebView).
* WebView/WebView.mm:
(-[WebView _boundsChanged]):
2009-04-28 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
......
......@@ -864,7 +864,12 @@ static bool runningTigerMail()
{
if (!NSEqualSizes(_private->lastLayoutSize, [self bounds].size)) {
Frame* frame = core([self mainFrame]);
frame->view()->resize([self bounds].size.width, [self bounds].size.height);
// FIXME: Viewless WebKit is broken with Safari banners (e.g., the Find banner). We'll have to figure out a way for
// Safari to communicate that this space is being consumed. For WebKit with document views, there's no
// need to do an explicit resize, since WebFrameViews have auto resizing turned on and will handle changing
// their bounds automatically. See <rdar://problem/6835573> for details.
if (!_private->useDocumentViews)
frame->view()->resize([self bounds].size.width, [self bounds].size.height);
frame->view()->setNeedsLayout();
[self setNeedsDisplay:YES];
_private->lastLayoutSize = [[self superview] bounds].size;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment