Commit 0dd92f00 authored by Kamila Hasanbega's avatar Kamila Hasanbega Committed by Commit Bot

Reland "[ios] Disables CookiesTestCase on iOS 12 under EG2."

This reverts commit 03e8e9c1.

Reason for revert: Not useful revert. 

Original change's description:
> Revert "[ios] Disables CookiesTestCase on iOS 12 under EG2."
> 
> This reverts commit 7c87047e.
> 
> Reason for revert: tree failure.
> 
> Original change's description:
> > [ios] Disables CookiesTestCase on iOS 12 under EG2.
> > 
> > BUG=1019670
> > 
> > Change-Id: I9a30133e4438819bb418b880feb07488cd3a4aec
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890630
> > Commit-Queue: Rohit Rao <rohitrao@chromium.org>
> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#710769}
> 
> TBR=rohitrao@chromium.org,olivierrobin@chromium.org,rkgibson@google.com
> 
> Change-Id: Iee07c30e9f08de1ad2457a300e809b173c03df56
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1019670
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890058
> Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710774}

TBR=rohitrao@chromium.org,olivierrobin@chromium.org,rkgibson@google.com,hkamila@chromium.org

Change-Id: I18af80235e3078a1ea5f4bbd7895a64108f53b0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890434Reviewed-by: default avatarRobbie Gibson <rkgibson@google.com>
Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710777}
parent bcb90ab7
...@@ -8,6 +8,7 @@ ...@@ -8,6 +8,7 @@
#import <XCTest/XCTest.h> #import <XCTest/XCTest.h>
#include "base/ios/ios_util.h"
#include "base/mac/foundation_util.h" #include "base/mac/foundation_util.h"
#include "base/strings/sys_string_conversions.h" #include "base/strings/sys_string_conversions.h"
#import "ios/chrome/test/earl_grey/chrome_earl_grey.h" #import "ios/chrome/test/earl_grey/chrome_earl_grey.h"
...@@ -109,6 +110,13 @@ NSString* const kIncognitoCookieValue = @"rainbow"; ...@@ -109,6 +110,13 @@ NSString* const kIncognitoCookieValue = @"rainbow";
// incognito tabs but not available in normal tabs. Cookies set in incognito // incognito tabs but not available in normal tabs. Cookies set in incognito
// tabs are also deleted when all incognito tabs are closed. // tabs are also deleted when all incognito tabs are closed.
- (void)testClearIncognitoFromMain { - (void)testClearIncognitoFromMain {
#if defined(CHROME_EARL_GREY_2)
// TODO(crbug.com/1019670): This test fails on iOS 12 under EG2.
if (!base::ios::IsRunningOnIOS13OrLater()) {
EARL_GREY_TEST_SKIPPED(@"Test fails on iOS 12 under EG2.");
}
#endif
// Loads a dummy page in normal tab. Sets a normal test cookie. Verifies that // Loads a dummy page in normal tab. Sets a normal test cookie. Verifies that
// the incognito test cookie is not found. // the incognito test cookie is not found.
[ChromeEarlGrey [ChromeEarlGrey
...@@ -156,6 +164,13 @@ NSString* const kIncognitoCookieValue = @"rainbow"; ...@@ -156,6 +164,13 @@ NSString* const kIncognitoCookieValue = @"rainbow";
// incognito tabs and then when new incognito tab is created the cookie will // incognito tabs and then when new incognito tab is created the cookie will
// not reappear. // not reappear.
- (void)testClearIncognitoFromIncognito { - (void)testClearIncognitoFromIncognito {
#if defined(CHROME_EARL_GREY_2)
// TODO(crbug.com/1019670): This test fails on iOS 12 under EG2.
if (!base::ios::IsRunningOnIOS13OrLater()) {
EARL_GREY_TEST_SKIPPED(@"Test fails on iOS 12 under EG2.");
}
#endif
// Loads a page in normal tab. // Loads a page in normal tab.
[ChromeEarlGrey [ChromeEarlGrey
loadURL:web::test::HttpServer::MakeUrl(kTestUrlNormalBrowsing)]; loadURL:web::test::HttpServer::MakeUrl(kTestUrlNormalBrowsing)];
...@@ -197,6 +212,13 @@ NSString* const kIncognitoCookieValue = @"rainbow"; ...@@ -197,6 +212,13 @@ NSString* const kIncognitoCookieValue = @"rainbow";
// Tests that a cookie set in normal tab is not available in an incognito tab. // Tests that a cookie set in normal tab is not available in an incognito tab.
- (void)testSwitchToIncognito { - (void)testSwitchToIncognito {
#if defined(CHROME_EARL_GREY_2)
// TODO(crbug.com/1019670): This test fails on iOS 12 under EG2.
if (!base::ios::IsRunningOnIOS13OrLater()) {
EARL_GREY_TEST_SKIPPED(@"Test fails on iOS 12 under EG2.");
}
#endif
// Sets cookie in normal tab. // Sets cookie in normal tab.
[ChromeEarlGrey [ChromeEarlGrey
loadURL:web::test::HttpServer::MakeUrl(kTestUrlNormalSetCookie)]; loadURL:web::test::HttpServer::MakeUrl(kTestUrlNormalSetCookie)];
...@@ -231,6 +253,13 @@ NSString* const kIncognitoCookieValue = @"rainbow"; ...@@ -231,6 +253,13 @@ NSString* const kIncognitoCookieValue = @"rainbow";
// Tests that a cookie set in incognito tab is only available in another // Tests that a cookie set in incognito tab is only available in another
// incognito tab. They are not available in a normal tab. // incognito tab. They are not available in a normal tab.
- (void)testSwitchToMain { - (void)testSwitchToMain {
#if defined(CHROME_EARL_GREY_2)
// TODO(crbug.com/1019670): This test fails on iOS 12 under EG2.
if (!base::ios::IsRunningOnIOS13OrLater()) {
EARL_GREY_TEST_SKIPPED(@"Test fails on iOS 12 under EG2.");
}
#endif
// Loads a page in normal tab and then switches to a new incognito tab. Sets // Loads a page in normal tab and then switches to a new incognito tab. Sets
// cookie in incognito tab. // cookie in incognito tab.
[ChromeEarlGrey [ChromeEarlGrey
...@@ -267,6 +296,13 @@ NSString* const kIncognitoCookieValue = @"rainbow"; ...@@ -267,6 +296,13 @@ NSString* const kIncognitoCookieValue = @"rainbow";
// Tests that a cookie set in a normal tab can be found in another normal tab. // Tests that a cookie set in a normal tab can be found in another normal tab.
- (void)testShareCookiesBetweenTabs { - (void)testShareCookiesBetweenTabs {
#if defined(CHROME_EARL_GREY_2)
// TODO(crbug.com/1019670): This test fails on iOS 12 under EG2.
if (!base::ios::IsRunningOnIOS13OrLater()) {
EARL_GREY_TEST_SKIPPED(@"Test fails on iOS 12 under EG2.");
}
#endif
// Loads page and sets cookie in first normal tab. // Loads page and sets cookie in first normal tab.
[ChromeEarlGrey [ChromeEarlGrey
loadURL:web::test::HttpServer::MakeUrl(kTestUrlNormalSetCookie)]; loadURL:web::test::HttpServer::MakeUrl(kTestUrlNormalSetCookie)];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment