Files app: Add closure to integration tests 4 of 4

Bug: 1064504
Change-Id: I25aa5a0d12c1a13f1b7c4e3a816e8ce34c1d2e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248387
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779668}

ui/file_manager/integration_tests/file_manager/BUILD.gn

@@ -40,6 +40,14 @@ js_type_check("closure_compile") {
     ":restore_prefs",
     ":search",
     ":share_and_manage_dialog",
+    ":sort_columns",
+    ":suggest_app_dialog",
+    ":tab_index",
+    ":tasks",
+    ":toolbar",
+    ":transfer",
+    ":traverse",
+    ":zip_files",
   ]
 }
 
@@ -216,3 +224,43 @@ js_library("share_and_manage_dialog") {
   testonly = true
   deps = []
 }
+
+js_library("sort_columns") {
+  testonly = true
+  deps = []
+}
+
+js_library("suggest_app_dialog") {
+  testonly = true
+  deps = []
+}
+
+js_library("tab_index") {
+  testonly = true
+  deps = []
+}
+
+js_library("tasks") {
+  testonly = true
+  deps = []
+}
+
+js_library("toolbar") {
+  testonly = true
+  deps = []
+}
+
+js_library("transfer") {
+  testonly = true
+  deps = []
+}
+
+js_library("traverse") {
+  testonly = true
+  deps = []
+}
+
+js_library("zip_files") {
+  testonly = true
+  deps = []
+}

ui/file_manager/integration_tests/file_manager/tab_index.js

@@ -243,7 +243,7 @@ testcase.tabindexFocusDirectorySelected = async () => {
  * @param {!Array<string>} initialElements Selectors of the elements which
  *     shows the Files app is ready. After all the elements show up, the
  *     tabfocus tests starts.
- * @param {Array<string>} expectedTabOrder Array with the IDs of the element
+ * @param {!Array<string>} expectedTabOrder Array with the IDs of the element
  *     with the corresponding order of expected tab-indexes.
  */
 async function tabindexFocus(

ui/file_manager/integration_tests/file_manager/tasks.js

@@ -11,16 +11,16 @@ class FakeTask {
   /**
    * @param {boolean} isDefault Whether the task is default or not.
    * @param {string} taskId Task ID.
-   * @param {string} title Title of the task.
+   * @param {string=} opt_title Title of the task.
    * @param {boolean=} opt_isGenericFileHandler Whether the task is a generic
    *     file handler.
    */
-  constructor(isDefault, taskId, title, opt_isGenericFileHandler) {
+  constructor(isDefault, taskId, opt_title, opt_isGenericFileHandler) {
     this.driveApp = false;
     this.iconUrl = 'chrome://theme/IDR_DEFAULT_FAVICON';  // Dummy icon
     this.isDefault = isDefault;
     this.taskId = taskId;
-    this.title = title;
+    this.title = opt_title;
     this.isGenericFileHandler = opt_isGenericFileHandler || false;
     Object.freeze(this);
   }
@@ -158,7 +158,7 @@ async function defaultTaskDialog(appId, expectedTaskId) {
       ]));
 
   // Wait for the dialog hidden, and the task is executed.
-  await remoteCall.waitForElementLost(appId, '#default-task-dialog', null);
+  await remoteCall.waitForElementLost(appId, '#default-task-dialog');
 
   // Execute the new default task. Click on "Open ▼" button.
   remoteCall.callRemoteTestUtil('fakeMouseClick', appId, ['#tasks']);

ui/file_manager/integration_tests/file_manager/transfer.js

@@ -229,9 +229,9 @@ async function transferBetweenVolumes(transferInfo) {
 
 /**
  * A list of transfer locations, for use with transferBetweenVolumes.
- * @enum{TransferLocationInfo}
+ * @enum {TransferLocationInfo}
  */
-const TRANSFER_LOCATIONS = Object.freeze({
+const TRANSFER_LOCATIONS = {
   drive: new TransferLocationInfo({
     breadcrumbsPath: '/My Drive',
     volumeName: 'drive',
@@ -306,7 +306,8 @@ const TRANSFER_LOCATIONS = Object.freeze({
       }),
     ]
   }),
-});
+};
+Object.freeze(TRANSFER_LOCATIONS);
 
 /**
  * Tests copying from Drive to Downloads.

ui/file_manager/integration_tests/remote_call.js

@@ -494,7 +494,7 @@ class RemoteCallFilesApp extends RemoteCall {
    * Waits until the given taskId appears in the executed task list.
    * @param {string} appId App window Id.
    * @param {string} taskId Task ID to watch.
-   * @param {Array<Object>} opt_replyArgs arguments to reply to executed task.
+   * @param {Array<Object>=} opt_replyArgs arguments to reply to executed task.
    * @return {Promise} Promise to be fulfilled when the task appears in the
    *     executed task list.
    */