Skip to content

GitLab

T
tangled
Commit 0debb3d4 authored by Dominique Fauteux-Chapleau's avatar Dominique Fauteux-Chapleau Committed by Commit Bot
Browse files
Options

Update Deep Scanning DLP file types. 

Update the Deep Scanning DLP supported file types to mirror those
currently supported internally.

Change-Id: I93036341678cf4138eba429f0abd327fc800b618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991996Reviewed-by: default avatarRoger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730953}
parent b13e768d
Hide whitespace changes
Inline Side-by-side
Showing with 15 additions and 37 deletions
chrome/browser/safe_browsing/cloud_content_scanning/deep_scanning_dialog_delegate.cc
View file @ 0debb3d4
......@@ -164,26 +164,19 @@ std::string GetFileMimeType(base::FilePath path) {
// File types supported for DLP scanning.
// Keep sorted for efficient access.
constexpr const std::array<const base::FilePath::CharType*, 36>
constexpr const std::array<const base::FilePath::CharType*, 21>
kSupportedDLPFileTypes = {
FILE_PATH_LITERAL(".7z"), FILE_PATH_LITERAL(".bzip"),
FILE_PATH_LITERAL(".cab"), FILE_PATH_LITERAL(".doc"),
FILE_PATH_LITERAL(".docx"), FILE_PATH_LITERAL(".eps"),
FILE_PATH_LITERAL(".gzip"), FILE_PATH_LITERAL(".hwp"),
FILE_PATH_LITERAL(".img_for_ocr"), FILE_PATH_LITERAL(".kml"),
FILE_PATH_LITERAL(".kmz"), FILE_PATH_LITERAL(".odp"),
FILE_PATH_LITERAL(".ods"), FILE_PATH_LITERAL(".odt"),
FILE_PATH_LITERAL(".pdf"), FILE_PATH_LITERAL(".ppt"),
FILE_PATH_LITERAL(".pptx"), FILE_PATH_LITERAL(".ps"),
FILE_PATH_LITERAL(".rar"), FILE_PATH_LITERAL(".rtf"),
FILE_PATH_LITERAL(".sdc"), FILE_PATH_LITERAL(".sdd"),
FILE_PATH_LITERAL(".sdw"), FILE_PATH_LITERAL(".sxc"),
FILE_PATH_LITERAL(".sxi"), FILE_PATH_LITERAL(".sxw"),
FILE_PATH_LITERAL(".tar"), FILE_PATH_LITERAL(".ttf"),
FILE_PATH_LITERAL(".txt"), FILE_PATH_LITERAL(".wml"),
FILE_PATH_LITERAL(".wpd"), FILE_PATH_LITERAL(".xls"),
FILE_PATH_LITERAL(".xlsx"), FILE_PATH_LITERAL(".xml"),
FILE_PATH_LITERAL(".xps"), FILE_PATH_LITERAL(".zip")};
FILE_PATH_LITERAL(".7z"), FILE_PATH_LITERAL(".bzip"),
FILE_PATH_LITERAL(".cab"), FILE_PATH_LITERAL(".doc"),
FILE_PATH_LITERAL(".docx"), FILE_PATH_LITERAL(".eps"),
FILE_PATH_LITERAL(".gzip"), FILE_PATH_LITERAL(".odt"),
FILE_PATH_LITERAL(".pdf"), FILE_PATH_LITERAL(".ppt"),
FILE_PATH_LITERAL(".pptx"), FILE_PATH_LITERAL(".ps"),
FILE_PATH_LITERAL(".rar"), FILE_PATH_LITERAL(".rtf"),
FILE_PATH_LITERAL(".tar"), FILE_PATH_LITERAL(".txt"),
FILE_PATH_LITERAL(".wpd"), FILE_PATH_LITERAL(".xls"),
FILE_PATH_LITERAL(".xlsx"), FILE_PATH_LITERAL(".xps"),
FILE_PATH_LITERAL(".zip")};
} // namespace
......
chrome/browser/safe_browsing/cloud_content_scanning/deep_scanning_dialog_delegate_unittest.cc
View file @ 0debb3d4
......@@ -1127,18 +1127,13 @@ TEST_F(DeepScanningDialogDelegateAuditOnlyTest, SupportedTypes) {
DeepScanningDialogDelegate::Data data;
ASSERT_TRUE(DeepScanningDialogDelegate::IsEnabled(profile(), url, &data));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.7z"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.bzip"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.cab"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.doc"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.docx"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.eps"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.gzip"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.hwp"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.img_for_ocr"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.kml"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.kmz"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.odp"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.ods"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.odt"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.pdf"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.ppt"));
......@@ -1146,21 +1141,11 @@ TEST_F(DeepScanningDialogDelegateAuditOnlyTest, SupportedTypes) {
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.ps"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.rar"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.rtf"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.sdc"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.sdd"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.sdw"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.7z"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.sxc"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.sxi"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.sxw"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.tar"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.ttf"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.txt"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.wml"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.wpd"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.xls"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.xlsx"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.xml"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.xps"));
data.paths.emplace_back(FILE_PATH_LITERAL("/tmp/foo.zip"));
......@@ -1175,8 +1160,8 @@ TEST_F(DeepScanningDialogDelegateAuditOnlyTest, SupportedTypes) {
base::BindOnce(
[](bool* called, const DeepScanningDialogDelegate::Data& data,
const DeepScanningDialogDelegate::Result& result) {
EXPECT_EQ(36u, data.paths.size());
ASSERT_EQ(36u, result.paths_results.size());
EXPECT_EQ(21u, data.paths.size());
EXPECT_EQ(21u, result.paths_results.size());
// The supported types should be marked as false.
for (const auto& result : result.paths_results)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment