Commit 0df0c5ff authored by mdjones's avatar mdjones Committed by Commit bot

Fix composited toolbar in incorrect position for Chrome Home

Previously resize events did not explicitly trigger renders from the
compositor. This went unnoticed because most of the UI existed at
the top of the screen which was largely unaffected by the resize
event. Now, the ToolbarSceneLayer is responsible for requesting
renders when it is at the bottom of the screen.

BUG=698111

Review-Url: https://codereview.chromium.org/2730183002
Cr-Commit-Position: refs/heads/master@{#455781}
parent b4478d57
...@@ -18,6 +18,7 @@ import org.chromium.chrome.browser.compositor.layouts.eventfilter.EventFilter; ...@@ -18,6 +18,7 @@ import org.chromium.chrome.browser.compositor.layouts.eventfilter.EventFilter;
import org.chromium.chrome.browser.compositor.overlays.SceneOverlay; import org.chromium.chrome.browser.compositor.overlays.SceneOverlay;
import org.chromium.chrome.browser.device.DeviceClassManager; import org.chromium.chrome.browser.device.DeviceClassManager;
import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager; import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
import org.chromium.chrome.browser.util.FeatureUtilities;
import org.chromium.chrome.browser.widget.ClipDrawableProgressBar.DrawingInfo; import org.chromium.chrome.browser.widget.ClipDrawableProgressBar.DrawingInfo;
import org.chromium.chrome.browser.widget.ControlContainer; import org.chromium.chrome.browser.widget.ControlContainer;
import org.chromium.ui.base.DeviceFormFactor; import org.chromium.ui.base.DeviceFormFactor;
...@@ -164,8 +165,12 @@ public class ToolbarSceneLayer extends SceneOverlayLayer implements SceneOverlay ...@@ -164,8 +165,12 @@ public class ToolbarSceneLayer extends SceneOverlayLayer implements SceneOverlay
} }
@Override @Override
public void onSizeChanged(float width, float height, float visibleViewportOffsetY, public void onSizeChanged(
int orientation) {} float width, float height, float visibleViewportOffsetY, int orientation) {
// If Chrome Home is enabled, a size change means the toolbar is now in a different
// location so a render is needed.
if (FeatureUtilities.isChromeHomeEnabled()) mRenderHost.requestRender();
}
@Override @Override
public void getVirtualViews(List<VirtualView> views) {} public void getVirtualViews(List<VirtualView> views) {}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment