GitLab

history/favicons: copies history_backend into favicons

My plan is to create a FaviconBackend with all the favicon
related functions. FaviconBackend will be an implementation
detail of HistoryBackend. HistoryService will continue to call
to HistoryBackend, but all favicon related functions in
HistoryBackend trivially forward to FaviconBackend.

FaviconBackend will indirectly depend upon HistoryBackend
for redirects. Because of this, it doesn't make sense to have
HistoryService talk directly to FaviconBackend.

This is a straight copy (with some very minor changes to appease the
presubmit checks) so that it'll be easy to see what actually changes.

BUG=1076463
TEST=covered by tests

Change-Id: Ia1e5345e4a632f52e79c5392090690d305975a7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314813
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791245}