[UserTimingL3] Throw TypeError on negative time stamp

According to the spec (https://w3c.github.io/user-timing/):
1. "If markOptions's startTime is negative, throw a TypeError.",
2. "If mark is negative, throw a TypeError." when "Convert a mark to a timestamp"

The CL is to add these two checks accordingly.

Bug: 953865
Change-Id: I8475870cc883dc8c3d3d4f3e65a9d5a0a2189a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691871Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676266}

third_party/blink/renderer/core/timing/performance_user_timing.cc

@@ -110,6 +110,11 @@ PerformanceMark* UserTiming::CreatePerformanceMark(
   DOMHighResTimeStamp start = 0.0;
   if (mark_options && mark_options->hasStartTime()) {
     start = mark_options->startTime();
+    if (start < 0.0) {
+      exception_state.ThrowTypeError("'" + mark_name +
+                                     "' cannot have a negative start time.");
+      return nullptr;
+    }
   } else {
     start = performance_->now();
   }
@@ -192,14 +197,20 @@ double UserTiming::FindExistingMarkStartTime(const AtomicString& mark_name,
   return value - timing->navigationStart();
 }
 
-double UserTiming::GetTimeOrFindMarkTime(const StringOrDouble& mark_or_time,
+double UserTiming::GetTimeOrFindMarkTime(const AtomicString& measure_name,
+                                         const StringOrDouble& mark_or_time,
                                          ExceptionState& exception_state) {
   if (mark_or_time.IsString()) {
     return FindExistingMarkStartTime(AtomicString(mark_or_time.GetAsString()),
                                      exception_state);
   }
   DCHECK(mark_or_time.IsDouble());
-  return mark_or_time.GetAsDouble();
+  const double time = mark_or_time.GetAsDouble();
+  if (time < 0.0) {
+    exception_state.ThrowTypeError("'" + measure_name +
+                                   "' cannot have a negative time stamp.");
+  }
+  return time;
 }
 
 PerformanceMeasure* UserTiming::Measure(ScriptState* script_state,
@@ -209,12 +220,15 @@ PerformanceMeasure* UserTiming::Measure(ScriptState* script_state,
                                         const ScriptValue& detail,
                                         ExceptionState& exception_state) {
   double start_time =
-      start.IsNull() ? 0.0 : GetTimeOrFindMarkTime(start, exception_state);
+      start.IsNull()
+          ? 0.0
+          : GetTimeOrFindMarkTime(measure_name, start, exception_state);
   if (exception_state.HadException())
     return nullptr;
 
-  double end_time = end.IsNull() ? performance_->now()
-                                 : GetTimeOrFindMarkTime(end, exception_state);
+  double end_time =
+      end.IsNull() ? performance_->now()
+                   : GetTimeOrFindMarkTime(measure_name, end, exception_state);
   if (exception_state.HadException())
     return nullptr;
 

third_party/blink/renderer/core/timing/performance_user_timing.h

@@ -71,7 +71,8 @@ class UserTiming final : public GarbageCollected<UserTiming> {
  private:
   double FindExistingMarkStartTime(const AtomicString& mark_name,
                                    ExceptionState&);
-  double GetTimeOrFindMarkTime(const StringOrDouble& mark_or_time,
+  double GetTimeOrFindMarkTime(const AtomicString& measure_name,
+                               const StringOrDouble& mark_or_time,
                                ExceptionState&);
 
   Member<Performance> performance_;

third_party/blink/web_tests/external/wpt/user-timing/measure-with-dict.html

@@ -96,10 +96,16 @@
   test(function() {
     this.add_cleanup(cleanupPerformanceTimeline);
     assert_throws(new TypeError(), function() {
-      self.performance.measure("wrongUsage2", {'start': 2}, 12);
+      self.performance.measure("optionsAndNumberEnd", {'start': 2}, 12);
     }, "measure should throw a TypeError when passed an options object and an end time");
     assert_throws(new TypeError(), function() {
-      self.performance.measure("wrongUsage3", {'start': 2}, 'mark1');
+      self.performance.measure("optionsAndMarkEnd", {'start': 2}, 'mark1');
     }, "measure should throw a TypeError when passed an options object and an end mark");
+    assert_throws(new TypeError(), function() {
+      self.performance.measure("negativeStartInOptions", {'start': -1});
+    }, "measure cannot have a negative time stamp.");
+    assert_throws(new TypeError(), function() {
+      self.performance.measure("negativeEndInOptions", {'end': -1});
+    }, "measure cannot have a negative time stamp for end.");
   }, "measure should throw a TypeError when passed an invalid argument combination");
 </script>

third_party/blink/web_tests/virtual/user-timing-l2/external/wpt/user-timing/measure-with-dict-expected.txt

 This is a testharness.js-based test.
 FAIL measure entries' detail and start/end are customizable Cannot read property 'name' of null
 FAIL measure should throw a TypeError when passed an invalid argument combination assert_throws: measure should throw a TypeError when passed an options object and an end time function "function() {
-      self.performance.measure("wrongUsage2", {'start': 2}, 12);
+      self.performance.measure("optionsAndNumberEnd", {'start': 2}, 12);
     }" threw object "SyntaxError: Failed to execute 'measure' on 'Performance': The mark '12' does not exist." ("SyntaxError") expected object "TypeError" ("TypeError")
 Harness: the test ran to completion.