Commit 0e12a58c authored by Justin Cohen's avatar Justin Cohen Committed by Commit Bot

Reland "Disable RememberCertDecision test."

This reverts commit ae5d1b92.

Reason for revert: This is still failing on ToTiOS.  Needs more
investigation.

Original change's description:
> Revert "Disable RememberCertDecision test."
> 
> This reverts commit 7b9599f6.
> 
> Reason for revert: Speculative revert to see if anything changed.
> 
> Original change's description:
> > Disable RememberCertDecision test.
> > 
> > TBR=rohitrao@chromium.org
> > 
> > Bug: 973635
> > Change-Id: Ibdd73fa2c40cbea322e22271dc02017cd2d9326a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656589
> > Reviewed-by: Eugene But <eugenebut@chromium.org>
> > Commit-Queue: Eugene But <eugenebut@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#668609}
> 
> TBR=rohitrao@chromium.org,eugenebut@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 973635
> Change-Id: I69295a9f56101678466744e38279a01f814503c2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729400
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682940}

TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 973635
Change-Id: If0f3d1855fae70340fbe6f55f1b3ca60335058e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732349Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683437}
parent 7132643d
...@@ -191,7 +191,8 @@ TEST_P(BadSslResponseTest, ReadFromSessionCertificateStorage) { ...@@ -191,7 +191,8 @@ TEST_P(BadSslResponseTest, ReadFromSessionCertificateStorage) {
// Tests navigation to a page with self signed SSL cert and allowing the load // Tests navigation to a page with self signed SSL cert and allowing the load
// via WebClient. Subsequent navigation should not call AllowCertificateError // via WebClient. Subsequent navigation should not call AllowCertificateError
// but always allow the load. // but always allow the load.
TEST_P(BadSslResponseTest, RememberCertDecision) { // TODO(crbug.com/973635): fix and reenable this test.
TEST_P(BadSslResponseTest, DISABLED_RememberCertDecision) {
// Allow the load via WebClient. // Allow the load via WebClient.
web_client()->SetAllowCertificateErrors(true); web_client()->SetAllowCertificateErrors(true);
GURL url(https_server_.GetURL("/echo")); GURL url(https_server_.GetURL("/echo"));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment