Commit 0e17ba26 authored by Yi Gu's avatar Yi Gu Committed by Commit Bot

Disable ThemeChangedWhenApplyingNewTheme on Linux ASAN

The test was flaky on Win and Mac but not after Jan 25 [1]. Disable it on
Linux for now.

[1]: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUwsSBUZsYWtlIkhjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEluc3RhbnRUaGVtZVRlc3QuVGhlbWVDaGFuZ2VkV2hlbkFwcGx5aW5nTmV3VGhlbWUM&show_all_occurrences=1

TBR=sweilun@chromium.org

Bug: 1045708
Change-Id: If47bee4e8eaca59e68138b57606c6e81d69a2090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025641Reviewed-by: default avatarYi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736032}
parent 19de8b52
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
#include "base/feature_list.h" #include "base/feature_list.h"
#include "base/macros.h" #include "base/macros.h"
#include "build/build_config.h"
#include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/extension_browsertest.h" #include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile.h"
...@@ -269,7 +270,15 @@ IN_PROC_BROWSER_TEST_F(InstantThemeTest, ThemeAppliedToNewTab) { ...@@ -269,7 +270,15 @@ IN_PROC_BROWSER_TEST_F(InstantThemeTest, ThemeAppliedToNewTab) {
EXPECT_EQ(css_text, new_tab_css_text); EXPECT_EQ(css_text, new_tab_css_text);
} }
IN_PROC_BROWSER_TEST_F(InstantThemeTest, ThemeChangedWhenApplyingNewTheme) { // The test is flaky on linux asan. crbug.com/1045708.
#if defined(OS_LINUX) && defined(ADDRESS_SANITIZER)
#define MAYBE_ThemeChangedWhenApplyingNewTheme \
DISABLED_ThemeChangedWhenApplyingNewTheme
#else
#define MAYBE_ThemeChangedWhenApplyingNewTheme ThemeChangedWhenApplyingNewTheme
#endif
IN_PROC_BROWSER_TEST_F(InstantThemeTest,
MAYBE_ThemeChangedWhenApplyingNewTheme) {
// On the existing tab. // On the existing tab.
ASSERT_EQ(1, browser()->tab_strip_model()->count()); ASSERT_EQ(1, browser()->tab_strip_model()->count());
ASSERT_EQ(0, browser()->tab_strip_model()->active_index()); ASSERT_EQ(0, browser()->tab_strip_model()->active_index());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment