Commit 0e1f29de authored by Vasilii Sukhanov's avatar Vasilii Sukhanov Committed by Commit Bot

Fix a crash in AutofillPopupViewNativeViews.

RemoveAllChildViews() deletes all the child views, thus, turning some members
holding dangling pointers. The code should NULL them.

Bug: 1023941
Change-Id: I642cff0f1a22e0c894fe4a46421a91182d662c15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914364Reviewed-by: default avatarIoana Pandele <ioanap@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715008}
parent 8c1f5761
...@@ -940,6 +940,9 @@ base::Optional<int32_t> AutofillPopupViewNativeViews::GetAxUniqueId() { ...@@ -940,6 +940,9 @@ base::Optional<int32_t> AutofillPopupViewNativeViews::GetAxUniqueId() {
void AutofillPopupViewNativeViews::CreateChildViews() { void AutofillPopupViewNativeViews::CreateChildViews() {
RemoveAllChildViews(true /* delete_children */); RemoveAllChildViews(true /* delete_children */);
rows_.clear(); rows_.clear();
scroll_view_ = nullptr;
body_container_ = nullptr;
footer_container_ = nullptr;
int line_number = 0; int line_number = 0;
bool has_footer = false; bool has_footer = false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment