Commit 0e26b213 authored by Jeremy Roman's avatar Jeremy Roman Committed by Commit Bot

Remove base::MakeUnique.

All call sites now use std::make_unique.

Bug: 755727
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I08adbff1480987b2c29bca8ad32b096a46d937ba
Reviewed-on: https://chromium-review.googlesource.com/944048
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540371}
parent e25dc47a
......@@ -18,13 +18,6 @@ std::unique_ptr<T> WrapUnique(T* ptr) {
return std::unique_ptr<T>(ptr);
}
// TODO(crbug.com/755727): Inline all uses.
template <typename T, typename... Args>
auto MakeUnique(Args&&... args)
-> decltype(std::make_unique<T>(std::forward<Args>(args)...)) {
return std::make_unique<T>(std::forward<Args>(args)...);
}
} // namespace base
#endif // BASE_MEMORY_PTR_UTIL_H_
......@@ -37,34 +37,4 @@ TEST(PtrUtilTest, WrapUnique) {
EXPECT_EQ(0u, DeleteCounter::count());
}
TEST(PtrUtilTest, MakeUniqueScalar) {
auto s = std::make_unique<std::string>();
EXPECT_EQ("", *s);
auto s2 = std::make_unique<std::string>("test");
EXPECT_EQ("test", *s2);
}
TEST(PtrUtilTest, MakeUniqueScalarWithMoveOnlyType) {
using MoveOnly = std::unique_ptr<std::string>;
auto p = std::make_unique<MoveOnly>(std::make_unique<std::string>("test"));
EXPECT_EQ("test", **p);
}
TEST(PtrUtilTest, MakeUniqueArray) {
EXPECT_EQ(0u, DeleteCounter::count());
auto a = std::make_unique<DeleteCounter[]>(5);
EXPECT_EQ(5u, DeleteCounter::count());
a.reset();
EXPECT_EQ(0u, DeleteCounter::count());
}
#if 0
// TODO(dcheng): Move this into a nocompile test.
TEST(PtrUtilTest, MakeUniqueArrayWithKnownBounds) {
auto a = std::make_unique<DeleteCounter[1]>();
auto b = std::make_unique<DeleteCounter[1]>(1);
}
#endif
} // namespace base
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment