Add a menu item for configuring configurable providers.

TEST=Tested manually with a fake provider extension.
BUG=474146

Review URL: https://codereview.chromium.org/1136193002

Cr-Commit-Position: refs/heads/master@{#329796}

chrome/app/chromeos_strings.grdp

@@ -244,6 +244,9 @@ Press any key to continue exploring.
   <message name="IDS_FILE_BROWSER_FORMAT_DEVICE_BUTTON_LABEL" desc="Title of the action for formatting removable device.">
     Format device
   </message>
+  <message name="IDS_FILE_BROWSER_CONFIGURE_VOLUME_BUTTON_LABEL" desc="Title of the action for configuring the selected volume.">
+    Configure
+  </message>
   <message name="IDS_FILE_BROWSER_UNMOUNT_DEVICE_BUTTON_LABEL" desc="Title of the action for unmounting removable device.">
     Eject device
   </message>

chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc

@@ -309,6 +309,8 @@ bool FileManagerPrivateGetStringsFunction::RunSync() {
   SET_STRING("CLOUD_IMPORT_TOOLTIP_SCANNING",
              IDS_FILE_BROWSER_CLOUD_IMPORT_TOOLTIP_SCANNING);
 
+  SET_STRING("CONFIGURE_VOLUME_BUTTON_LABEL",
+             IDS_FILE_BROWSER_CONFIGURE_VOLUME_BUTTON_LABEL);
   SET_STRING("CONFIRM_MOBILE_DATA_USE",
              IDS_FILE_BROWSER_CONFIRM_MOBILE_DATA_USE);
   SET_STRING("CONFIRM_MOBILE_DATA_USE_PLURAL",

ui/file_manager/file_manager/background/js/mock_volume_manager.js

@@ -110,14 +110,15 @@ MockVolumeManager.createMockVolumeInfo = function(type, volumeId, label) {
       type,
       volumeId,
       fileSystem,
-      '',     // error
-      '',     // deviceType
-      '',     // devicePath
-      false,  // isReadonly
+      '',      // error
+      '',      // deviceType
+      '',      // devicePath
+      false,   // isReadonly
       {isCurrentProfile: true, displayName: ''},  // profile
-      label,  // label
-      '',     // extensionId
-      false); // hasMedia
+      label,   // label
+      '',      // extensionId
+      false,   // hasMedia
+      false);  // configurable
 
   return volumeInfo;
 };

ui/file_manager/file_manager/background/js/volume_manager.js

@@ -26,6 +26,7 @@
  *     volume. Empty for native volumes.
  * @param {boolean} hasMedia When true the volume has been identified
  *     as containing media such as photos or videos.
+ * @param {boolean} configurable When true, then the volume can be configured.
  */
 function VolumeInfo(
     volumeType,
@@ -38,7 +39,8 @@ function VolumeInfo(
     profile,
     label,
     extensionId,
-    hasMedia) {
+    hasMedia,
+    configurable) {
   this.volumeType_ = volumeType;
   this.volumeId_ = volumeId;
   this.fileSystem_ = fileSystem;
@@ -80,6 +82,7 @@ function VolumeInfo(
   this.profile_ = Object.freeze(profile);
   this.extensionId_ = extensionId;
   this.hasMedia_ = hasMedia;
+  this.configurable_ = configurable;
 }
 
 VolumeInfo.prototype = /** @struct */ {
@@ -161,6 +164,12 @@ VolumeInfo.prototype = /** @struct */ {
    */
   get hasMedia() {
     return this.hasMedia_;
+  },
+  /**
+   * @return {boolean} True if the volume is configurable.
+   */
+  get configurable() {
+    return this.configurable_;
   }
 };
 
@@ -245,20 +254,44 @@ volumeManagerUtil.createVolumeInfo = function(volumeMetadata) {
   }
 
   console.debug('Requesting file system.');
+  var configurable = false;
+
   return new Promise(
       function(resolve, reject) {
-        chrome.fileSystem.requestFileSystem(
-            {
-              volumeId: volumeMetadata.volumeId,
-              writable: !volumeMetadata.isReadOnly
-            },
-            function(isolatedFileSystem) {
-              if (chrome.runtime.lastError)
+        if (volumeMetadata.volumeType !==
+            VolumeManagerCommon.VolumeType.PROVIDED) {
+          resolve();
+        }
+
+        chrome.fileManagerPrivate.getProvidingExtensions(
+            function(extensions) {
+              if (chrome.runtime.lastError) {
                 reject(chrome.runtime.lastError.message);
-              else
-                resolve(isolatedFileSystem);
+                return;
+              }
+              configurable = extensions.some(function(extension) {
+                return extension.extensionId === volumeMetadata.extensionId &&
+                    extension.configurable;
+              });
+              resolve();
             });
       })
+      .then(
+          function() {
+            return new Promise(function(resolve, reject) {
+              chrome.fileSystem.requestFileSystem(
+                  {
+                    volumeId: volumeMetadata.volumeId,
+                    writable: !volumeMetadata.isReadOnly
+                  },
+                  function(isolatedFileSystem) {
+                    if (chrome.runtime.lastError)
+                      reject(chrome.runtime.lastError.message);
+                    else
+                      resolve(isolatedFileSystem);
+                  });
+            });
+          })
       .then(
           /**
            * @param {!FileSystem} isolatedFileSystem
@@ -313,7 +346,8 @@ volumeManagerUtil.createVolumeInfo = function(volumeMetadata) {
                   volumeMetadata.profile,
                   localizedLabel,
                   volumeMetadata.extensionId,
-                  volumeMetadata.hasMedia);
+                  volumeMetadata.hasMedia,
+                  configurable);
       })
       .catch(
           /**
@@ -335,7 +369,8 @@ volumeManagerUtil.createVolumeInfo = function(volumeMetadata) {
                 volumeMetadata.profile,
                 localizedLabel,
                 volumeMetadata.extensionId,
-                volumeMetadata.hasMedia);
+                volumeMetadata.hasMedia,
+                configurable);
           });
 };
 

ui/file_manager/file_manager/background/js/volume_manager_unittest.js

@@ -254,7 +254,8 @@ function testVolumeInfoListWhenReady(callback) {
       /* profile */ {},
       /* label */ null,
       /* extensionid */ null,
-      /* hasMedia */ false);
+      /* hasMedia */ false,
+      /* configurable */ false);
   list.add(volumeInfo);
   var promiseAfterAdd = list.whenVolumeInfoReady('volumeId');
   reportPromise(Promise.all([promiseBeforeAdd, promiseAfterAdd]).then(

ui/file_manager/file_manager/foreground/js/file_manager_commands.js

@@ -321,7 +321,8 @@ CommandHandler.prototype.onCommand_ = function(event) {
   if (this.shouldIgnoreEvents_())
     return;
   var handler = CommandHandler.COMMANDS_[event.command.id];
-  handler.execute.call(/** @type {Command} */ (this), event, this.fileManager_);
+  handler.execute.call(/** @type {Command} */ (handler), event,
+                       this.fileManager_);
 };
 
 /**
@@ -333,7 +334,7 @@ CommandHandler.prototype.onCanExecute_ = function(event) {
   if (this.shouldIgnoreEvents_())
     return;
   var handler = CommandHandler.COMMANDS_[event.command.id];
-  handler.canExecute.call(/** @type {Command} */ (this), event,
+  handler.canExecute.call(/** @type {Command} */ (handler), event,
                           this.fileManager_);
 };
 
@@ -383,7 +384,7 @@ CommandHandler.COMMANDS_['unmount'] = /** @type {Command} */ ({
     var root = CommandUtil.getCommandEntry(event.target);
     if (!root)
       return;
-    var locationInfo = this.fileManager_.volumeManager.getLocationInfo(root);
+    var locationInfo = fileManager.volumeManager.getLocationInfo(root);
     var rootType =
         locationInfo && locationInfo.isRootEntry && locationInfo.rootType;
 
@@ -1320,3 +1321,73 @@ CommandHandler.COMMANDS_['install-new-extension'] = /** @type {Command} */ ({
   },
   canExecute: CommandUtil.canExecuteAlways
 });
+
+/**
+ * Configures the currently selected volume.
+ */
+CommandHandler.COMMANDS_['configure'] = (function() {
+  /**
+   * @constructor
+   * @implements {Command}
+   */
+  var ConfigureCommand = function() {
+  };
+
+  ConfigureCommand.prototype = {
+    __proto__: Command.prototype,
+
+    /**
+     * @param {EventTarget} element
+     * @param {!FileManager} fileManager
+     * @return {VolumeInfo}
+     * @private
+     */
+    getElementVolumeInfo_: function(element, fileManager) {
+      if (element instanceof VolumeItem)
+        return element.volumeInfo;
+      if (element instanceof ShortcutItem) {
+        return element.entry && fileManager.volumeManager.getVolumeInfo(
+            element.entry);
+      }
+    },
+
+    /**
+     * If the command is executed on the navigation list, then use it's volume
+     * info, otherwise use the currently opened volume.
+     *
+     * @param {!Event} event
+     * @param {!FileManager} fileManager
+     * @return {VolumeInfo}
+     * @private
+     */
+    getCommandVolumeInfo_: function(event, fileManager) {
+      var currentDirEntry = fileManager.directoryModel.getCurrentDirEntry();
+      return this.getElementVolumeInfo_(event.target, fileManager) ||
+          currentDirEntry && fileManager.volumeManager.getVolumeInfo(
+              currentDirEntry);
+    },
+
+    /**
+     * @override
+     */
+    execute: function(event, fileManager) {
+      var volumeInfo = this.getCommandVolumeInfo_(event, fileManager);
+      if (volumeInfo && volumeInfo.configurable) {
+        fileManager.providersModel.requestConfigure(
+            assert(volumeInfo.extensionId));
+      }
+    },
+
+    /**
+     * @override
+     */
+    canExecute: function(event, fileManager) {
+      var volumeInfo = this.getCommandVolumeInfo_(event, fileManager);
+      event.canExecute = volumeInfo && volumeInfo.configurable;
+      event.command.setHidden(!event.canExecute);
+    }
+  };
+
+  return new ConfigureCommand();
+})();
+

ui/file_manager/file_manager/foreground/js/providers_model.js

@@ -145,3 +145,15 @@ ProvidersModel.prototype.requestMount = function(extensionId) {
             console.error(chrome.runtime.lastError.message);
       });
 };
+
+/**
+ * @param {string} extensionId
+ */
+ProvidersModel.prototype.requestConfigure = function(extensionId) {
+  chrome.fileManagerPrivate.configureProvidedFileSystem(
+      assert(extensionId),
+      function() {
+        if (chrome.runtime.lastError)
+            console.error(chrome.runtime.lastError.message);
+      });
+};

ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

@@ -460,6 +460,15 @@ VolumeItem.prototype = {
   get entry() {
     return this.volumeInfo_.displayRoot;
   },
+  /**
+   * @type {!VolumeInfo}
+   */
+  get volumeInfo() {
+    return this.volumeInfo_;
+  },
+  /**
+   * @type {!NavigationModelVolumeItem}
+   */
   get modelItem() {
     return this.modelItem_;
   }

ui/file_manager/file_manager/main.html

@@ -235,6 +235,7 @@
       <command id="unmount" i18n-values="label:UNMOUNT_DEVICE_BUTTON_LABEL"
                shortcut="U+0045-Shift-Ctrl"><!-- Shortcut: 'Shift-Ctrl-E' -->
       <command id="format" i18n-values="label:FORMAT_DEVICE_BUTTON_LABEL">
+      <command id="configure" i18n-values="label:CONFIGURE_VOLUME_BUTTON_LABEL">
 
       <command id="volume-help" i18n-values="label:DRIVE_MENU_HELP">
       <command id="drive-buy-more-space"
@@ -297,6 +298,7 @@
     </cr-menu>
 
     <cr-menu id="roots-context-menu" class="chrome-menu" >
+      <cr-menu-item command="#configure"></cr-menu-item>
       <cr-menu-item command="#unmount"></cr-menu-item>
       <cr-menu-item command="#format"></cr-menu-item>
       <cr-menu-item command="#remove-folder-shortcut"></cr-menu-item>
@@ -322,6 +324,7 @@
       <cr-menu-item id="gear-menu-newwindow" command="#new-window"></cr-menu-item>
       <cr-menu-item id="gear-menu-newfolder" command="#new-folder"></cr-menu-item>
       <hr>
+      <cr-menu-item command="#configure"></cr-menu-item>
       <cr-menu-item id="gear-menu-toggle-hidden-files"
                     command="#toggle-hidden-files"></cr-menu-item>
       <cr-menu-item id="gear-menu-drive-sync-settings"