[Switch Access] Update BUILD file

The deps/externs for various files got out of sync with what was
actually being used. This brings those back to sync.

Bug: None
Change-Id: I1c1bf99abf3825e4e2acca7945a482cf98021bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877147Reviewed-by: Chris Hall <chrishall@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#709962}

chrome/browser/resources/chromeos/switch_access/BUILD.gn

@@ -205,6 +205,7 @@ js_type_check("closure_compile") {
 
 js_library("auto_scan_manager") {
   deps = [
+    ":switch_access_constants",
     ":switch_access_interface",
   ]
 }
@@ -222,6 +223,7 @@ js_library("back_button_node") {
   ]
   deps = [
     ":rect_helper",
+    ":switch_access_constants",
     ":switch_access_node",
   ]
   externs_list = [
@@ -234,10 +236,11 @@ js_library("commands") {
   deps = [
     ":switch_access_interface",
   ]
+  externs_list = [ "$externs_path/accessibility_private.js" ]
 }
 
 js_library("event_helper") {
-  externs_list = [ "$externs_path/automation.js" ]
+  externs_list = [ "$externs_path/accessibility_private.js" ]
 }
 
 js_library("focus_ring_manager") {
@@ -254,12 +257,19 @@ js_library("keyboard_node") {
     "nodes/keyboard_node.js",
   ]
   deps = [
+    ":event_helper",
     ":node_wrapper",
     ":rect_helper",
+    ":switch_access_constants",
     ":switch_access_node",
     ":switch_access_predicate",
+    "../chromevox:constants",
+    "../chromevox:tree_walker",
+  ]
+  externs_list = [
+    "$externs_path/accessibility_private.js",
+    "$externs_path/automation.js",
   ]
-  externs_list = [ "$externs_path/automation.js" ]
 }
 
 js_library("menu_manager") {
@@ -268,17 +278,27 @@ js_library("menu_manager") {
     ":menu_panel_interface",
     ":node_wrapper",
     ":rect_helper",
-    ":switch_access_interface",
+    ":switch_access_constants",
     ":switch_access_node",
     ":switch_access_predicate",
+    ":text_navigation_manager",
+    "../chromevox:constants",
+    "../chromevox:tree_walker",
+  ]
+  externs_list = [
+    "$externs_path/accessibility_private.js",
+    "$externs_path/automation.js",
+    "$externs_path/clipboard.js",
   ]
-  externs_list = [ "$externs_path/accessibility_private.js" ]
 }
 
 js_library("menu_panel") {
   deps = [
+    ":menu_manager",
+    ":switch_access_constants",
     ":switch_access_interface",
   ]
+  externs_list = [ "$externs_path/chrome_extensions.js" ]
 }
 
 js_library("menu_panel_interface") {
@@ -286,21 +306,15 @@ js_library("menu_panel_interface") {
 
 js_library("navigation_manager") {
   deps = [
-    ":event_helper",
     ":focus_ring_manager",
     ":keyboard_node",
     ":menu_manager",
     ":menu_panel_interface",
     ":node_wrapper",
-    ":rect_helper",
     ":switch_access_constants",
-    ":switch_access_interface",
     ":switch_access_node",
     ":switch_access_predicate",
     ":system_menu_node",
-    ":text_navigation_manager",
-    "../chromevox:constants",
-    "../chromevox:tree_walker",
   ]
   externs_list = [
     "$externs_path/accessibility_private.js",
@@ -314,23 +328,27 @@ js_library("node_wrapper") {
   ]
   deps = [
     ":back_button_node",
+    ":switch_access_constants",
     ":switch_access_node",
     ":switch_access_predicate",
+    "../chromevox:constants",
+    "../chromevox:tree_walker",
+  ]
+  externs_list = [
+    "$externs_path/accessibility_private.js",
+    "$externs_path/automation.js",
   ]
-  externs_list = [ "$externs_path/automation.js" ]
 }
 
 js_library("preferences") {
   deps = [
+    ":switch_access_constants",
     ":switch_access_interface",
   ]
   externs_list = [ "$externs_path/settings_private.js" ]
 }
 
 js_library("rect_helper") {
-  deps = [
-    ":switch_access_constants",
-  ]
   externs_list = [ "$externs_path/accessibility_private.js" ]
 }
 
@@ -338,14 +356,17 @@ js_library("switch_access") {
   deps = [
     ":auto_scan_manager",
     ":commands",
+    ":menu_manager",
     ":menu_panel_interface",
     ":navigation_manager",
     ":preferences",
+    ":switch_access_constants",
+    ":switch_access_interface",
+    "../chromevox:constants",
+    "../chromevox:tree_walker",
   ]
   externs_list = [
     "$externs_path/automation.js",
-    "$externs_path/chrome_extensions.js",
-    "$externs_path/clipboard.js",
     "$externs_path/command_line_private.js",
   ]
 }
@@ -363,10 +384,20 @@ js_library("switch_access_node") {
   sources = [
     "nodes/switch_access_node.js",
   ]
-  externs_list = [ "$externs_path/automation.js" ]
+  deps = [
+    ":switch_access_constants",
+  ]
+  externs_list = [
+    "$externs_path/accessibility_private.js",
+    "$externs_path/automation.js",
+  ]
 }
 
 js_library("switch_access_predicate") {
+  deps = [
+    ":switch_access_constants",
+    ":switch_access_node",
+  ]
   externs_list = [ "$externs_path/automation.js" ]
 }
 
@@ -375,7 +406,9 @@ js_library("system_menu_node") {
     "nodes/system_menu_node.js",
   ]
   deps = [
+    ":event_helper",
     ":node_wrapper",
+    ":switch_access_constants",
     ":switch_access_node",
   ]
   externs_list = [ "$externs_path/automation.js" ]
@@ -384,7 +417,9 @@ js_library("system_menu_node") {
 js_library("text_navigation_manager") {
   deps = [
     ":event_helper",
-    ":switch_access_constants",
   ]
-  externs_list = [ "$externs_path/accessibility_private.js" ]
+  externs_list = [
+    "$externs_path/accessibility_private.js",
+    "$externs_path/automation.js",
+  ]
 }

chrome/browser/resources/chromeos/switch_access/menu_panel.js

@@ -104,7 +104,7 @@ class Panel {
   /**
    * Sets the actions in the menu panel to the actions in |actions| from
    * the menu with the given |menuId|.
-   * @param {!Array<string>} actions
+   * @param {!Array<SAConstants.MenuAction>} actions
    * @param {!SAConstants.MenuId} menuId
    * @public
    */

chrome/browser/resources/chromeos/switch_access/nodes/switch_access_node.js

@@ -245,14 +245,14 @@ class SARootNode {
   }
 
   /**
-   * @param {AutomationNode} automationNode
+   * @param {chrome.automation.AutomationNode} automationNode
    * @return {boolean}
    */
   isEquivalentTo(automationNode) {
     return false;
   }
 
-  /** @return {AutomationNode} */
+  /** @return {chrome.automation.AutomationNode} */
   get automationNode() {}
 
   /** Called when a group is exiting. */

chrome/browser/resources/chromeos/switch_access/switch_access.js

@@ -116,7 +116,7 @@ class SwitchAccess {
    */
   moveForward() {
     if (this.navigationManager_) this.navigationManager_.moveForward();
-    this.onMoveForwardForTesting_ && this.onMoveForwardForTesting_();
+    if (this.onMoveForwardForTesting_) this.onMoveForwardForTesting_();
   }
 
   /**