Commit 0e6a25b8 authored by David Munro's avatar David Munro Committed by Commit Bot

crostini: Add a link to the PLX dashboard scripts in a comment.

We keep forgetting to update the dashboard scripts when adding new
return codes, add a link in a comment above the enum so we hopefully
remember.

Test: None
Bug: None
Change-Id: I07a8b8b49118dc19bf352282f658ab95f1d21253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220115
Commit-Queue: David Munro <davidmunro@google.com>
Auto-Submit: David Munro <davidmunro@google.com>
Reviewed-by: default avatarJoel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773998}
parent 0fa61969
...@@ -17,11 +17,14 @@ ...@@ -17,11 +17,14 @@
namespace crostini { namespace crostini {
// Result types for various callbacks etc. // Result types for various callbacks etc.
//
// WARNING: Do not remove or re-order these values, as they are used in user // WARNING: Do not remove or re-order these values, as they are used in user
// visible error messages and logs. New entries should only be added to the end. // visible error messages and logs. New entries should only be added to the end.
// This message was added during development of M74, error codes from prior // This message was added during development of M74, error codes from prior
// versions may differ from the numbering here. // versions may differ from the numbering here.
// If you add anything here make sure to also update enums.xml and the plx
// scripts in
// https://plx.corp.google.com/home2/home/collections/c16e3c1474497b821
enum class CrostiniResult { enum class CrostiniResult {
SUCCESS = 0, SUCCESS = 0,
// DBUS_ERROR = 1, // DBUS_ERROR = 1,
...@@ -75,6 +78,8 @@ enum class CrostiniResult { ...@@ -75,6 +78,8 @@ enum class CrostiniResult {
NEVER_FINISHED = 49, NEVER_FINISHED = 49,
CONTAINER_SETUP_FAILED = 50, CONTAINER_SETUP_FAILED = 50,
kMaxValue = CONTAINER_SETUP_FAILED, kMaxValue = CONTAINER_SETUP_FAILED,
// When adding a new value, check you've followed the steps in the comment at
// the top of this enum.
}; };
enum class InstallLinuxPackageProgressStatus { enum class InstallLinuxPackageProgressStatus {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment