Commit 0e91897c authored by tasak@google.com's avatar tasak@google.com

Remove public web methods using toV8 with empty context.

The following chromium commits fixed chromium code to use  new
public web methods which take creation context and isolate:

WebBlob
- https://src.chromium.org/viewvc/chrome?view=rev&revision=275420

WebDOMError
- https://src.chromium.org/viewvc/chrome?view=rev&revision=275396

WebDOMFileSystem:
- https://src.chromium.org/viewvc/chrome?view=rev&revision=275291

BUG=369451

Review URL: https://codereview.chromium.org/326573002

git-svn-id: svn://svn.chromium.org/blink/trunk@175777 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 18d41ecd
...@@ -90,11 +90,6 @@ v8::Handle<v8::Value> WebBlob::toV8Value(v8::Handle<v8::Object> creationContext, ...@@ -90,11 +90,6 @@ v8::Handle<v8::Value> WebBlob::toV8Value(v8::Handle<v8::Object> creationContext,
return toV8(m_private.get(), creationContext, isolate); return toV8(m_private.get(), creationContext, isolate);
} }
v8::Handle<v8::Value> WebBlob::toV8Value()
{
return toV8Value(v8::Handle<v8::Object>(), v8::Isolate::GetCurrent());
}
WebBlob::WebBlob(const PassRefPtrWillBeRawPtr<WebCore::Blob>& blob) WebBlob::WebBlob(const PassRefPtrWillBeRawPtr<WebCore::Blob>& blob)
: m_private(blob) : m_private(blob)
{ {
......
...@@ -69,13 +69,6 @@ WebString WebDOMError::message() const ...@@ -69,13 +69,6 @@ WebString WebDOMError::message() const
return m_private->message(); return m_private->message();
} }
v8::Handle<v8::Value> WebDOMError::toV8Value()
{
if (!m_private.get())
return v8::Handle<v8::Value>();
return toV8(m_private.get(), v8::Handle<v8::Object>(), v8::Isolate::GetCurrent());
}
v8::Handle<v8::Value> WebDOMError::toV8Value(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate) v8::Handle<v8::Value> WebDOMError::toV8Value(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{ {
if (!m_private.get()) if (!m_private.get())
......
...@@ -118,14 +118,6 @@ WebURL WebDOMFileSystem::rootURL() const ...@@ -118,14 +118,6 @@ WebURL WebDOMFileSystem::rootURL() const
return m_private->rootURL(); return m_private->rootURL();
} }
// FIXME: should be removed after fixing chrome side code.
v8::Handle<v8::Value> WebDOMFileSystem::toV8Value()
{
if (!m_private.get())
return v8::Handle<v8::Value>();
return toV8Value(v8::Handle<v8::Object>(), toIsolate(m_private->executionContext()));
}
v8::Handle<v8::Value> WebDOMFileSystem::toV8Value(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate) v8::Handle<v8::Value> WebDOMFileSystem::toV8Value(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{ {
if (!m_private.get()) if (!m_private.get())
...@@ -133,16 +125,6 @@ v8::Handle<v8::Value> WebDOMFileSystem::toV8Value(v8::Handle<v8::Object> creatio ...@@ -133,16 +125,6 @@ v8::Handle<v8::Value> WebDOMFileSystem::toV8Value(v8::Handle<v8::Object> creatio
return toV8(m_private.get(), creationContext, isolate); return toV8(m_private.get(), creationContext, isolate);
} }
// FIXME: should be removed after fixing chrome side code.
v8::Handle<v8::Value> WebDOMFileSystem::createV8Entry(
const WebString& path,
EntryType entryType)
{
if (!m_private.get())
return v8::Handle<v8::Value>();
return createV8Entry(path, entryType, v8::Handle<v8::Object>(), toIsolate(m_private->executionContext()));
}
v8::Handle<v8::Value> WebDOMFileSystem::createV8Entry( v8::Handle<v8::Value> WebDOMFileSystem::createV8Entry(
const WebString& path, const WebString& path,
EntryType entryType, EntryType entryType,
......
...@@ -75,8 +75,6 @@ public: ...@@ -75,8 +75,6 @@ public:
bool isNull() const { return m_private.isNull(); } bool isNull() const { return m_private.isNull(); }
BLINK_EXPORT v8::Handle<v8::Value> toV8Value(v8::Handle<v8::Object> creationContext, v8::Isolate*); BLINK_EXPORT v8::Handle<v8::Value> toV8Value(v8::Handle<v8::Object> creationContext, v8::Isolate*);
// FIXME: remove the following toV8Value after fixing chromium code.
BLINK_EXPORT v8::Handle<v8::Value> toV8Value();
#if BLINK_IMPLEMENTATION #if BLINK_IMPLEMENTATION
explicit WebBlob(const PassRefPtrWillBeRawPtr<WebCore::Blob>&); explicit WebBlob(const PassRefPtrWillBeRawPtr<WebCore::Blob>&);
......
...@@ -66,10 +66,6 @@ public: ...@@ -66,10 +66,6 @@ public:
BLINK_EXPORT WebString name() const; BLINK_EXPORT WebString name() const;
BLINK_EXPORT WebString message() const; BLINK_EXPORT WebString message() const;
// FIXME: toV8Value() will be removed after modifying
// //src/extensions/renderer/file_system_natives.cc to use
// toV8Value(v8::Handle<v8::Obejct>, v8::Isolate*).
BLINK_EXPORT v8::Handle<v8::Value> toV8Value();
BLINK_EXPORT v8::Handle<v8::Value> toV8Value(v8::Handle<v8::Object> creationContext, v8::Isolate*); BLINK_EXPORT v8::Handle<v8::Value> toV8Value(v8::Handle<v8::Object> creationContext, v8::Isolate*);
#if BLINK_IMPLEMENTATION #if BLINK_IMPLEMENTATION
......
...@@ -93,10 +93,6 @@ public: ...@@ -93,10 +93,6 @@ public:
BLINK_EXPORT WebFileSystem::Type type() const; BLINK_EXPORT WebFileSystem::Type type() const;
BLINK_EXPORT WebURL rootURL() const; BLINK_EXPORT WebURL rootURL() const;
BLINK_EXPORT v8::Handle<v8::Value> toV8Value();
BLINK_EXPORT v8::Handle<v8::Value> createV8Entry(
const WebString& path,
EntryType);
BLINK_EXPORT v8::Handle<v8::Value> toV8Value(v8::Handle<v8::Object> creationContext, v8::Isolate*); BLINK_EXPORT v8::Handle<v8::Value> toV8Value(v8::Handle<v8::Object> creationContext, v8::Isolate*);
BLINK_EXPORT v8::Handle<v8::Value> createV8Entry( BLINK_EXPORT v8::Handle<v8::Value> createV8Entry(
const WebString& path, const WebString& path,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment