Commit 0e9adc6c authored by allada's avatar allada Committed by Commit bot

[Devtools] Fix network grouping experiment

There was a regression recently that was fixed (https://codereview.chromium.org/2838673003/) but broke the network grouping experiment. This patch fixes that regression.

We were deeming the item as not needing to be removed or added without checking if there is a new parent.

R=dgozman,pfeldman
BUG=718116

Review-Url: https://codereview.chromium.org/2856863006
Cr-Commit-Position: refs/heads/master@{#469250}
parent adda99ec
...@@ -843,10 +843,10 @@ Network.NetworkLogView = class extends UI.VBox { ...@@ -843,10 +843,10 @@ Network.NetworkLogView = class extends UI.VBox {
var request = node.request(); var request = node.request();
this._timeCalculator.updateBoundaries(request); this._timeCalculator.updateBoundaries(request);
this._durationCalculator.updateBoundaries(request); this._durationCalculator.updateBoundaries(request);
if (node[Network.NetworkLogView._isFilteredOutSymbol] === isFilteredOut) var newParent = this._parentNodeForInsert(node);
if (node[Network.NetworkLogView._isFilteredOutSymbol] === isFilteredOut && node.parent === newParent)
continue; continue;
node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut; node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
var newParent = this._parentNodeForInsert(node);
var removeFromParent = node.parent && (isFilteredOut || node.parent !== newParent); var removeFromParent = node.parent && (isFilteredOut || node.parent !== newParent);
if (removeFromParent) { if (removeFromParent) {
var parent = node.parent; var parent = node.parent;
......
...@@ -195,6 +195,7 @@ Network.NetworkPanel = class extends UI.Panel { ...@@ -195,6 +195,7 @@ Network.NetworkPanel = class extends UI.Panel {
var setting = Common.settings.createSetting('networkGrouping', ''); var setting = Common.settings.createSetting('networkGrouping', '');
this._panelToolbar.appendToolbarItem(new UI.ToolbarSettingComboBox(options, setting, Common.UIString('Group by'))); this._panelToolbar.appendToolbarItem(new UI.ToolbarSettingComboBox(options, setting, Common.UIString('Group by')));
setting.addChangeListener(event => this._networkLogView.setGrouping(/** @type {string} */ (event.data))); setting.addChangeListener(event => this._networkLogView.setGrouping(/** @type {string} */ (event.data)));
this._networkLogView.setGrouping(/** @type {string} */ (setting.get()));
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment