Fixing loop to count up from the bottom instead of the top.
The loop that adds prefixes from 1 billion to 3 billion has been broken since it was modified in Feb 27, 2014, change 2b59b0a6. It didn't survive the change from signed to unsigned integers meaning that this test function has effectively been disabled. This bug was found by VC++'s /analyze which said: src\chrome\browser\safe_browsing\prefix_set_unittest.cc(280) : warning C6294: Ill-defined for-loop: initial condition does not satisfy test. Loop body not executed. BUG=427616 Review URL: https://codereview.chromium.org/779163002 Cr-Commit-Position: refs/heads/master@{#307071}
Showing
Please register or sign in to comment