Revert "[fuchsia] handle RetrySystemUpdate reboot reason"

This reverts commit 394a78b4.

Reason for revert: this breaks something

Original change's description:
> [fuchsia] handle RetrySystemUpdate reboot reason
>
> In this change, we add support for RetrySystemUpdate. Also, we stop
> mapping `RebootSource::OTA` to `StateControlRebootReason::SystemUpdate`
> because reboots for system updates should only be called from
> fuchsia.git -- the code we remove isn't being run anyway.
>
> BUG=fuchsia:64591
> TEST=cast_reboot_unittests
>
> Change-Id: Ic15f86d31d3985d2fa5a2a3957c5ca61066cd476
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600053
> Reviewed-by: Sergey Volk <servolk@chromium.org>
> Commit-Queue: Zach Kirschenbaum <zkbaum@google.com>
> Cr-Commit-Position: refs/heads/master@{#838871}

TBR=spang@chromium.org,servolk@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,zkbaum@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: fuchsia:64591
Change-Id: I9a2dd0fe105b1750c733925a8320a2f4e71cded2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611448Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Zach Kirschenbaum <zkbaum@google.com>
Cr-Commit-Position: refs/heads/master@{#840361}

chromecast/system/reboot/reboot_fuchsia.cc

@@ -91,10 +91,8 @@ bool RebootShlib::RebootNow(RebootSource reboot_source) {
       reason = StateControlRebootReason::USER_REQUEST;
       break;
     case RebootSource::OTA:
-      // We are only expecting OTAs initiated by the platform via the
-      // fuchsia.hardware.power.statecontrol/Admin FIDL service.
-      NOTREACHED();
-      return false;
+      reason = StateControlRebootReason::SYSTEM_UPDATE;
+      break;
     case RebootSource::OVERHEAT:
       reason = StateControlRebootReason::HIGH_TEMPERATURE;
       break;
@@ -177,7 +175,6 @@ RebootShlib::RebootSource RebootUtil::GetLastRebootSource() {
     case RebootReason::USER_REQUEST:
       return RebootShlib::RebootSource::API;
     case RebootReason::SYSTEM_UPDATE:
-    case RebootReason::RETRY_SYSTEM_UPDATE:
       return RebootShlib::RebootSource::OTA;
     case RebootReason::HIGH_TEMPERATURE:
       return RebootShlib::RebootSource::OVERHEAT;

chromecast/system/reboot/reboot_fuchsia_test.cc

@@ -66,6 +66,8 @@ const RebootReasonParam kRebootReasonParams[] = {
     // Graceful reboot reasons.
     {RebootReason::USER_REQUEST, RebootShlib::RebootSource::API, true,
      StateControlRebootReason::USER_REQUEST},
+    {RebootReason::SYSTEM_UPDATE, RebootShlib::RebootSource::OTA, true,
+     StateControlRebootReason::SYSTEM_UPDATE},
     {RebootReason::HIGH_TEMPERATURE, RebootShlib::RebootSource::OVERHEAT, true,
      StateControlRebootReason::HIGH_TEMPERATURE},
     {RebootReason::SESSION_FAILURE, RebootShlib::RebootSource::SW_OTHER, true},
@@ -234,33 +236,6 @@ TEST_F(RebootFuchsiaTest, GetLastRebootSourceWithoutGranularReason) {
               Eq(RebootShlib::RebootSource::SW_OTHER));
 }
 
-TEST_F(RebootFuchsiaTest, RebootSourceOtaNotSupported) {
-  EXPECT_DEATH(RebootShlib::RebootNow(RebootShlib::RebootSource::OTA), "");
-}
-
-fuchsia::feedback::LastReboot GenerateLastReboot(bool graceful,
-                                                 RebootReason reason) {
-  fuchsia::feedback::LastReboot last_reboot;
-  last_reboot.set_graceful(graceful);
-  last_reboot.set_reason(reason);
-  return last_reboot;
-}
-
-// SystemUpdate-related reasons must be handled separately. Otherwise, they will
-// fail RebootNowSendsFidlRebootReason because RebootNow panics when given
-// RebootShlib::RebootSource::OTA.
-TEST_F(RebootFuchsiaTest, RebootReasonSystemUpdate) {
-  SetLastReboot(GenerateLastReboot(true, RebootReason::SYSTEM_UPDATE));
-  EXPECT_THAT(RebootUtil::GetLastRebootSource(),
-              Eq(RebootShlib::RebootSource::OTA));
-}
-
-TEST_F(RebootFuchsiaTest, RebootReasonRetrySystemUpdate) {
-  SetLastReboot(GenerateLastReboot(true, RebootReason::RETRY_SYSTEM_UPDATE));
-  EXPECT_THAT(RebootUtil::GetLastRebootSource(),
-              Eq(RebootShlib::RebootSource::OTA));
-}
-
 class RebootFuchsiaParamTest : public RebootFuchsiaTest,
                                public ::testing::WithParamInterface<RebootReasonParam> {
  public:
@@ -274,7 +249,12 @@ TEST_P(RebootFuchsiaParamTest, RebootNowSendsFidlRebootReason) {
 }
 
 TEST_P(RebootFuchsiaParamTest, GetLastRebootSourceTranslatesReasonFromFuchsia) {
-  SetLastReboot(GenerateLastReboot(GetParam().graceful, GetParam().reason));
+  fuchsia::feedback::LastReboot last_reboot;
+  last_reboot.set_graceful(GetParam().graceful);
+  last_reboot.set_reason(GetParam().reason);
+  EXPECT_TRUE(last_reboot.has_graceful());
+  EXPECT_TRUE(last_reboot.has_reason());
+  SetLastReboot(std::move(last_reboot));
   EXPECT_THAT(RebootUtil::GetLastRebootSource(), Eq(GetParam().source));
 }