[CrOS Settings] Un-const OsSettingsPerPageStringsProvider::AddUiStrings()

This function was const, but this required some derived classes to have
to be refactored in unintended ways. Removing to help unblock future
changes.

Bug: 1069849
Change-Id: I612b3b2cde668beca6373792c94cec2422c77583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155175
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760233}

chrome/browser/ui/webui/settings/chromeos/bluetooth_strings_provider.cc

@@ -61,7 +61,7 @@ BluetoothStringsProvider::~BluetoothStringsProvider() {
 }
 
 void BluetoothStringsProvider::AddUiStrings(
-    content::WebUIDataSource* html_source) const {
+    content::WebUIDataSource* html_source) {
   static constexpr webui::LocalizedString kLocalizedStrings[] = {
       {"bluetoothConnected", IDS_SETTINGS_BLUETOOTH_CONNECTED},
       {"bluetoothConnectedWithBattery",

chrome/browser/ui/webui/settings/chromeos/bluetooth_strings_provider.h

@@ -28,7 +28,7 @@ class BluetoothStringsProvider : public OsSettingsPerPageStringsProvider,
 
  private:
   // OsSettingsPerPageStringsProvider:
-  void AddUiStrings(content::WebUIDataSource* html_source) const override;
+  void AddUiStrings(content::WebUIDataSource* html_source) override;
 
   // device::BluetoothAdapter::Observer:
   void AdapterPresentChanged(device::BluetoothAdapter* adapter,

chrome/browser/ui/webui/settings/chromeos/internet_strings_provider.cc

@@ -84,7 +84,7 @@ InternetStringsProvider::InternetStringsProvider(Profile* profile,
 InternetStringsProvider::~InternetStringsProvider() = default;
 
 void InternetStringsProvider::AddUiStrings(
-    content::WebUIDataSource* html_source) const {
+    content::WebUIDataSource* html_source) {
   static constexpr webui::LocalizedString kLocalizedStrings[] = {
       {"internetAddConnection", IDS_SETTINGS_INTERNET_ADD_CONNECTION},
       {"internetAddConnectionExpandA11yLabel",

chrome/browser/ui/webui/settings/chromeos/internet_strings_provider.h

@@ -30,7 +30,7 @@ class InternetStringsProvider
 
  private:
   // OsSettingsPerPageStringsProvider:
-  void AddUiStrings(content::WebUIDataSource* html_source) const override;
+  void AddUiStrings(content::WebUIDataSource* html_source) override;
 
   // network_config::mojom::CrosNetworkConfigObserver:
   void OnActiveNetworksChanged(

chrome/browser/ui/webui/settings/chromeos/multidevice_strings_provider.cc

@@ -85,7 +85,7 @@ MultiDeviceStringsProvider::~MultiDeviceStringsProvider() {
 }
 
 void MultiDeviceStringsProvider::AddUiStrings(
-    content::WebUIDataSource* html_source) const {
+    content::WebUIDataSource* html_source) {
   static constexpr webui::LocalizedString kLocalizedStrings[] = {
       {"multidevicePageTitle", IDS_SETTINGS_MULTIDEVICE},
       {"multideviceSetupButton", IDS_SETTINGS_MULTIDEVICE_SETUP_BUTTON},

chrome/browser/ui/webui/settings/chromeos/multidevice_strings_provider.h

@@ -30,7 +30,7 @@ class MultiDeviceStringsProvider
 
  private:
   // OsSettingsPerPageStringsProvider:
-  void AddUiStrings(content::WebUIDataSource* html_source) const override;
+  void AddUiStrings(content::WebUIDataSource* html_source) override;
 
   // multidevice_setup::MultiDeviceSetupClient::Observer:
   void OnHostStatusChanged(

chrome/browser/ui/webui/settings/chromeos/os_settings_per_page_strings_provider.h

@@ -52,7 +52,7 @@ class OsSettingsPerPageStringsProvider {
       const OsSettingsPerPageStringsProvider& other) = delete;
 
   // Adds strings to be displayed in the UI via loadTimeData.
-  virtual void AddUiStrings(content::WebUIDataSource* html_source) const = 0;
+  virtual void AddUiStrings(content::WebUIDataSource* html_source) = 0;
 
  protected:
   static base::string16 GetHelpUrlWithBoard(const std::string& original_url);