Commit 0ecd06fe authored by kbr@chromium.org's avatar kbr@chromium.org

Revert 272478 "Always define _HAS_EXCEPTIONS=0 on Windows"

Caused assertion failures in multiple test suites.

BUG=82385,377008

> Always define _HAS_EXCEPTIONS=0 on Windows
> 
> Previously we would not define it in component builds because it didn't work with old versions of MSVC. These days it should work.
> 
> The macro is extra important for Clang, which doesn't currently support exceptions on Windows.
> 
> BUG=82385
> 
> Review URL: https://codereview.chromium.org/287193012

TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/289343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272610 0039d316-1c4b-4281-b951-d872f2087c98
parent 59d4decd
......@@ -4851,7 +4851,6 @@
'CERT_CHAIN_PARA_HAS_EXTRA_FIELDS',
'WIN32_LEAN_AND_MEAN',
'_ATL_NO_OPENGL',
'_HAS_EXCEPTIONS=0',
],
'conditions': [
['buildtype=="Official"', {
......@@ -4911,6 +4910,11 @@
],
},
],
['component=="static_library"', {
'defines': [
'_HAS_EXCEPTIONS=0',
],
}],
['secure_atl', {
'defines': [
'_SECURE_ATL',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment