Skip to content

GitLab

T
tangled
Commit 0ef6c52b authored by Hans Wennborg's avatar Hans Wennborg Committed by Commit Bot
Browse files
Options

Android test exclusions: don't exclude blink_heap_unittests 

The test does pass on some bots, e.g. [1], and it's not clear
why it was being excluded. If there's a legitimate reason for it
not running on Android, let's figure it out and get a bug filed.

Sheriffs: if this causes the test to start failing on Android bots,
please file a bug with information about the error, put the exclusion
back and reference the bug.

Bug: 842698

 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343

Change-Id: Ib7fdf46abf1ddf6b9fdb63c908c1f35040e4d468
Reviewed-on: https://chromium-review.googlesource.com/1057727
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558341}
parent efbd67fa
Hide whitespace changes
Inline Side-by-side
Showing with 242 additions and 11 deletions
testing/buildbot/chromium.android.fyi.json
View file @ 0ef6c52b
...@@ -623,6 +623,12 @@ ...@@ -623,6 +623,12 @@
}, },
"test": "base_unittests" "test": "base_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": false
},
"test": "blink_heap_unittests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": false "can_use_on_swarming_builders": false
...@@ -806,6 +812,12 @@ ...@@ -806,6 +812,12 @@
}, },
"test": "base_unittests" "test": "base_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": false
},
"test": "blink_heap_unittests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": false "can_use_on_swarming_builders": false
...@@ -1970,6 +1982,50 @@ ...@@ -1970,6 +1982,50 @@
}, },
"test": "base_unittests" "test": "base_unittests"
}, },
{
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices"
],
"merge": {
"args": [
"--bucket",
"chromium-result-details",
"--test-name",
"blink_heap_unittests"
],
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"swarming": {
"can_use_on_swarming_builders": true,
"cipd_packages": [
{
"cipd_package": "infra/tools/luci/logdog/butler/${platform}",
"location": "bin",
"revision": "git_revision:ff387eadf445b24c935f1cf7d6ddd279f8a6b04c"
}
],
"dimension_sets": [
{
"device_os": "NRD91N",
"device_type": "bullhead"
}
],
"expiration": 10800,
"hard_timeout": 960,
"output_links": [
{
"link": [
"https://luci-logdog.appspot.com/v/?s",
"=android%2Fswarming%2Flogcats%2F",
"${TASK_ID}%2F%2B%2Funified_logcats"
],
"name": "shard #${SHARD_INDEX} logcats"
}
]
},
"test": "blink_heap_unittests"
},
{ {
"args": [ "args": [
"--gs-results-bucket=chromium-result-details", "--gs-results-bucket=chromium-result-details",
...@@ -3388,6 +3444,12 @@ ...@@ -3388,6 +3444,12 @@
}, },
"test": "base_unittests" "test": "base_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": false
},
"test": "blink_heap_unittests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": false "can_use_on_swarming_builders": false
...@@ -3582,6 +3644,12 @@ ...@@ -3582,6 +3644,12 @@
}, },
"test": "base_unittests" "test": "base_unittests"
}, },
{
"swarming": {
"can_use_on_swarming_builders": false
},
"test": "blink_heap_unittests"
},
{ {
"swarming": { "swarming": {
"can_use_on_swarming_builders": false "can_use_on_swarming_builders": false
......
testing/buildbot/chromium.android.json
View file @ 0ef6c52b
...@@ -3769,6 +3769,49 @@ ...@@ -3769,6 +3769,49 @@
}, },
"test": "base_unittests" "test": "base_unittests"
}, },
{
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices"
],
"merge": {
"args": [
"--bucket",
"chromium-result-details",
"--test-name",
"blink_heap_unittests"
],
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"swarming": {
"can_use_on_swarming_builders": true,
"cipd_packages": [
{
"cipd_package": "infra/tools/luci/logdog/butler/${platform}",
"location": "bin",
"revision": "git_revision:ff387eadf445b24c935f1cf7d6ddd279f8a6b04c"
}
],
"dimension_sets": [
{
"device_os": "KTU84Z",
"device_type": "flo"
}
],
"expiration": 10800,
"output_links": [
{
"link": [
"https://luci-logdog.appspot.com/v/?s",
"=android%2Fswarming%2Flogcats%2F",
"${TASK_ID}%2F%2B%2Funified_logcats"
],
"name": "shard #${SHARD_INDEX} logcats"
}
]
},
"test": "blink_heap_unittests"
},
{ {
"args": [ "args": [
"--gs-results-bucket=chromium-result-details", "--gs-results-bucket=chromium-result-details",
...@@ -5230,6 +5273,50 @@ ...@@ -5230,6 +5273,50 @@
}, },
"test": "base_unittests" "test": "base_unittests"
}, },
{
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices"
],
"merge": {
"args": [
"--bucket",
"chromium-result-details",
"--test-name",
"blink_heap_unittests"
],
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"swarming": {
"can_use_on_swarming_builders": true,
"cipd_packages": [
{
"cipd_package": "infra/tools/luci/logdog/butler/${platform}",
"location": "bin",
"revision": "git_revision:ff387eadf445b24c935f1cf7d6ddd279f8a6b04c"
}
],
"dimension_sets": [
{
"device_os": "LMY48I",
"device_type": "hammerhead"
}
],
"expiration": 10800,
"hard_timeout": 960,
"output_links": [
{
"link": [
"https://luci-logdog.appspot.com/v/?s",
"=android%2Fswarming%2Flogcats%2F",
"${TASK_ID}%2F%2B%2Funified_logcats"
],
"name": "shard #${SHARD_INDEX} logcats"
}
]
},
"test": "blink_heap_unittests"
},
{ {
"args": [ "args": [
"--gs-results-bucket=chromium-result-details", "--gs-results-bucket=chromium-result-details",
...@@ -6827,6 +6914,50 @@ ...@@ -6827,6 +6914,50 @@
}, },
"test": "base_unittests" "test": "base_unittests"
}, },
{
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices"
],
"merge": {
"args": [
"--bucket",
"chromium-result-details",
"--test-name",
"blink_heap_unittests"
],
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"swarming": {
"can_use_on_swarming_builders": true,
"cipd_packages": [
{
"cipd_package": "infra/tools/luci/logdog/butler/${platform}",
"location": "bin",
"revision": "git_revision:ff387eadf445b24c935f1cf7d6ddd279f8a6b04c"
}
],
"dimension_sets": [
{
"device_os": "LMY49B",
"device_type": "flo"
}
],
"expiration": 10800,
"hard_timeout": 120,
"output_links": [
{
"link": [
"https://luci-logdog.appspot.com/v/?s",
"=android%2Fswarming%2Flogcats%2F",
"${TASK_ID}%2F%2B%2Funified_logcats"
],
"name": "shard #${SHARD_INDEX} logcats"
}
]
},
"test": "blink_heap_unittests"
},
{ {
"args": [ "args": [
"--gs-results-bucket=chromium-result-details", "--gs-results-bucket=chromium-result-details",
...@@ -11623,6 +11754,49 @@ ...@@ -11623,6 +11754,49 @@
}, },
"test": "base_unittests" "test": "base_unittests"
}, },
{
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices"
],
"merge": {
"args": [
"--bucket",
"chromium-result-details",
"--test-name",
"blink_heap_unittests"
],
"script": "//build/android/pylib/results/presentation/test_results_presentation.py"
},
"swarming": {
"can_use_on_swarming_builders": true,
"cipd_packages": [
{
"cipd_package": "infra/tools/luci/logdog/butler/${platform}",
"location": "bin",
"revision": "git_revision:ff387eadf445b24c935f1cf7d6ddd279f8a6b04c"
}
],
"dimension_sets": [
{
"device_os": "MRA58Z",
"device_type": "flo"
}
],
"expiration": 10800,
"output_links": [
{
"link": [
"https://luci-logdog.appspot.com/v/?s",
"=android%2Fswarming%2Flogcats%2F",
"${TASK_ID}%2F%2B%2Funified_logcats"
],
"name": "shard #${SHARD_INDEX} logcats"
}
]
},
"test": "blink_heap_unittests"
},
{ {
"args": [ "args": [
"--gs-results-bucket=chromium-result-details", "--gs-results-bucket=chromium-result-details",
......
testing/buildbot/test_suite_exceptions.pyl
View file @ 0ef6c52b
...@@ -122,17 +122,6 @@ ...@@ -122,17 +122,6 @@
}, },
'blink_heap_unittests': { 'blink_heap_unittests': {
'remove_from': [ 'remove_from': [
# On chromium.android, unclear why these aren't run on all bots.
'KitKat Tablet Tester',
'Lollipop Phone Tester',
'Lollipop Tablet Tester',
'Marshmallow Tablet Tester',
'Nougat Phone Tester',
# chromium.android.fyi
'Jelly Bean Tester',
'Lollipop Consumer Tester',
'Unswarmed N5 Tests Dummy Builder',
'Unswarmed N5X Tests Dummy Builder',
# chromium.clang # chromium.clang
'CrWinAsan', 'CrWinAsan',
'CrWinAsan(dll)', 'CrWinAsan(dll)',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment