Commit 0f103994 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Commit Bot

Revert "Test oobe screens for public session login"

This reverts commit 144e9e93.

Reason for revert: suspect causing PublicSessionWithTermsOfServiceOobeTestImpl timeout on Linux ChromiumOS MSan Tests

https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12947
browser_tests deterministic failures:
PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/0
PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/1
PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/2
PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/5
PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/6
PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/7

Original change's description:
> Test oobe screens for public session login
> 
> Tests that the terms of service screen (if required by policy) is the
> only screen shown to public session user during login.
> 
> To make environment setup for different configurations eaiser, separate
> end to end test setup steps from OobeInteractiveUiTest into a separate
> mixin.
> 
> BUG=none
> 
> Change-Id: Ib6580e2b4f63f59c7b262fb0f79982197251724c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607103
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Commit-Queue: Toni Baržić <tbarzic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#660269}

TBR=tbarzic@chromium.org,alemate@chromium.org

Change-Id: Iaa5b1073e336935452a184eeb67a4808fb9626fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614005Reviewed-by: default avatarTakashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#660328}
parent 88c12f35
...@@ -5,7 +5,6 @@ ...@@ -5,7 +5,6 @@
#include "ash/login/ui/arrow_button_view.h" #include "ash/login/ui/arrow_button_view.h"
#include "ash/resources/vector_icons/vector_icons.h" #include "ash/resources/vector_icons/vector_icons.h"
#include "ui/accessibility/ax_node_data.h"
#include "ui/gfx/canvas.h" #include "ui/gfx/canvas.h"
#include "ui/gfx/paint_vector_icon.h" #include "ui/gfx/paint_vector_icon.h"
...@@ -46,11 +45,6 @@ void ArrowButtonView::PaintButtonContents(gfx::Canvas* canvas) { ...@@ -46,11 +45,6 @@ void ArrowButtonView::PaintButtonContents(gfx::Canvas* canvas) {
// Draw arrow icon. // Draw arrow icon.
views::ImageButton::PaintButtonContents(canvas); views::ImageButton::PaintButtonContents(canvas);
} }
void ArrowButtonView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
// TODO(tbarzic): Fix this - https://crbug.com/961930.
if (GetAccessibleName().empty())
node_data->SetNameExplicitlyEmpty();
}
void ArrowButtonView::SetBackgroundColor(SkColor color) { void ArrowButtonView::SetBackgroundColor(SkColor color) {
background_color_ = color; background_color_ = color;
......
...@@ -20,7 +20,6 @@ class ArrowButtonView : public LoginButton { ...@@ -20,7 +20,6 @@ class ArrowButtonView : public LoginButton {
// views::Button: // views::Button:
void PaintButtonContents(gfx::Canvas* canvas) override; void PaintButtonContents(gfx::Canvas* canvas) override;
void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
// Set background color of the button. // Set background color of the button.
void SetBackgroundColor(SkColor color); void SetBackgroundColor(SkColor color);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment