Commit 0f17c8e0 authored by Antonio Gomes's avatar Antonio Gomes Committed by Commit Bot

Switch RTCCertificateGenerator away from WebString

... and use WTF::String instead now that RTCCertificateGenerator
resides solely in blink/renderer.

BUG=787254
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ie87bdada35e05a868763b52ffc2ae8778c0e355f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882130
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712033}
parent 248d7dd2
......@@ -139,8 +139,8 @@ bool RTCCertificateGenerator::IsSupportedKeyParams(
}
rtc::scoped_refptr<rtc::RTCCertificate> RTCCertificateGenerator::FromPEM(
blink::WebString pem_private_key,
blink::WebString pem_certificate) {
String pem_private_key,
String pem_certificate) {
rtc::scoped_refptr<rtc::RTCCertificate> certificate =
rtc::RTCCertificate::FromPEM(rtc::RTCCertificatePEM(
pem_private_key.Utf8(), pem_certificate.Utf8()));
......
......@@ -9,8 +9,8 @@
#include "base/macros.h"
#include "third_party/blink/public/platform/web_rtc_key_params.h"
#include "third_party/blink/public/platform/web_string.h"
#include "third_party/blink/renderer/modules/modules_export.h"
#include "third_party/blink/renderer/platform/wtf/text/wtf_string.h"
#include "third_party/webrtc/api/peer_connection_interface.h"
namespace base {
......@@ -25,8 +25,6 @@ using RTCCertificateCallback =
// Chromium's WebRTCCertificateGenerator implementation; uses the
// PeerConnectionIdentityStore/SSLIdentity::Generate to generate the identity,
// rtc::RTCCertificate and blink::RTCCertificate.
//
// TODO(crbug.com/787254): Convert use of WebString to WTF::String.
class MODULES_EXPORT RTCCertificateGenerator {
public:
RTCCertificateGenerator() {}
......@@ -52,9 +50,8 @@ class MODULES_EXPORT RTCCertificateGenerator {
// Creates a certificate from the PEM strings. See also
// |rtc::RTCCertificate::ToPEM|.
rtc::scoped_refptr<rtc::RTCCertificate> FromPEM(
blink::WebString pem_private_key,
blink::WebString pem_certificate);
rtc::scoped_refptr<rtc::RTCCertificate> FromPEM(String pem_private_key,
String pem_certificate);
private:
DISALLOW_COPY_AND_ASSIGN(RTCCertificateGenerator);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment