Commit 0f374eff authored by Oystein Eftevaag's avatar Oystein Eftevaag Committed by Commit Bot

Reland "Enable Perfetto by default for all telemetry tests"

This is a reland of 32c8ebbe

Relanding after https://chromium-review.googlesource.com/c/chromium/src/+/1225306

Original change's description:
> Enable Perfetto by default for all telemetry tests
>
> This will use Perfetto instead of TraceLog for all
> trace-based Telemetry tests running on Mac/Windows/Android.
>
> R=nednguyen@google.com
>
> Bug: 839084
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
> Reviewed-on: https://chromium-review.googlesource.com/1176119
> Commit-Queue: oysteine <oysteine@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#585368}

TBR=nednguyen@google.com

Change-Id: I31b69483281f9fb34c5083888b8f45f00ca95e6e
Reviewed-on: https://chromium-review.googlesource.com/1208955Reviewed-by: default avataroysteine <oysteine@chromium.org>
Reviewed-by: default avatarAnnie Sullivan <sullivan@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592127}
parent 7679bb89
......@@ -18,11 +18,6 @@ class _LoadingBase(perf_benchmark.PerfBenchmark):
options = {'pageset_repeat': 2}
def SetExtraBrowserOptions(self, options):
options.AppendExtraBrowserArgs([
'--enable-features=TracingPerfettoBackend',
])
def CreateCoreTimelineBasedMeasurementOptions(self):
tbm_options = timeline_based_measurement.Options()
loading_metrics_category.AugmentOptionsForLoadingMetrics(tbm_options)
......
......@@ -106,12 +106,18 @@ class PerfBenchmark(benchmark.Benchmark):
options.AppendExtraBrowserArgs(
'--disable-gpu-process-for-dx12-vulkan-info-collection')
# TODO(crbug.com/881469): remove this once Webview support surface
# synchronization.
if 'android-webview' in options.browser_type:
options.AppendExtraBrowserArgs(
'--disable-features=SurfaceSynchronization')
# Switch Chrome to use Perfetto instead of TraceLog as the tracing backend,
# needed until the feature gets turned on by default everywhere.
if options.browser_type != 'reference':
options.AppendExtraBrowserArgs(
'--enable-features=TracingPerfettoBackend')
self.SetExtraBrowserOptions(options)
@staticmethod
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment