Commit 0f5f861f authored by Tomasz Wiszkowski's avatar Tomasz Wiszkowski Committed by Commit Bot

Update delimiter used for subtype logging.

This change corrects the delimiter used for subtype logging from
previously used . to a correct i.

There are no functional changes included in this CL.

Bug: 1110104
Change-Id: Ie2b8b4b7fe764d85e5e936853a42bf8057b0e73d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321512Reviewed-by: default avatarJustin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Ender 💬 = 🕐 (ping me for faster reviews) <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#792272}
parent e6d2a205
......@@ -197,7 +197,7 @@ void AppendAvailableAutocompletion(size_t type,
std::ostringstream subtype_str;
for (auto subtype : subtypes) {
if (subtype_str.tellp() > 0)
subtype_str << '.';
subtype_str << 'i';
subtype_str << subtype;
}
......
......@@ -881,25 +881,25 @@ TEST_F(AutocompleteProviderTest, UpdateAssistedQueryStats) {
// properly handled and reported as the same suggestion type.
AssistedQueryStatsTestData test_data[] = {
{AutocompleteMatchType::SEARCH_SUGGEST,
"chrome.0.0i13.22.99j46i27.31l2j46i27.31.42j46i27.31",
"chrome.0.0i13i22i99j46i27i31l2j46i27i31i42j46i27i31",
{22, 99, 13, 99}},
// The next two matches should be detected as the same type, despite
// repeated subtype match.
{AutocompleteMatchType::SEARCH_SUGGEST_ENTITY,
"chrome.1.0i13.22.99j46i27.31l2j46i27.31.42j46i27.31",
"chrome.1.0i13i22i99j46i27i31l2j46i27i31i42j46i27i31",
{27, 31}},
{AutocompleteMatchType::SEARCH_SUGGEST_ENTITY,
"chrome.2.0i13.22.99j46i27.31l2j46i27.31.42j46i27.31",
"chrome.2.0i13i22i99j46i27i31l2j46i27i31i42j46i27i31",
{27, 31, 27}},
// This match should not be bundled together with previous two, because
// it comes with additional subtype information (42).
{AutocompleteMatchType::SEARCH_SUGGEST_ENTITY,
"chrome.3.0i13.22.99j46i27.31l2j46i27.31.42j46i27.31",
"chrome.3.0i13i22i99j46i27i31l2j46i27i31i42j46i27i31",
{27, 31, 42}},
// This match should not be bundled together with the group before,
// because these items are not adjacent.
{AutocompleteMatchType::SEARCH_SUGGEST_ENTITY,
"chrome.4.0i13.22.99j46i27.31l2j46i27.31.42j46i27.31",
"chrome.4.0i13i22i99j46i27i31l2j46i27i31i42j46i27i31",
{27, 31}},
};
SCOPED_TRACE("Complex set of matches with repetitive subtypes");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment