Commit 0f6851e7 authored by Jonathan Ross's avatar Jonathan Ross Committed by Commit Bot

Remove old Compositing.Surface* Histograms

Two old Histograms are coming up on expiry, and we haven't used them in
a long time. So I'm marking them Oboslete now:
  Compositing.SurfaceDependencyDeadline.Duration*
  Compositing.SurfaceManager.AliveSurfaces*

Bug: 1140020, 1140021
Change-Id: Ibbfd90c72edb2a206cf114b77682116061c613b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505965Reviewed-by: default avatarkylechar <kylechar@chromium.org>
Reviewed-by: default avatarStephen Chenney <schenney@chromium.org>
Auto-Submit: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822176}
parent 0219d22b
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include "components/viz/service/surfaces/surface_dependency_deadline.h" #include "components/viz/service/surfaces/surface_dependency_deadline.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_number_conversions.h" #include "base/strings/string_number_conversions.h"
#include "base/time/tick_clock.h" #include "base/time/tick_clock.h"
#include "components/viz/common/quads/frame_deadline.h" #include "components/viz/common/quads/frame_deadline.h"
...@@ -38,12 +37,7 @@ base::Optional<base::TimeDelta> SurfaceDependencyDeadline::Cancel() { ...@@ -38,12 +37,7 @@ base::Optional<base::TimeDelta> SurfaceDependencyDeadline::Cancel() {
deadline_.reset(); deadline_.reset();
base::TimeDelta duration = tick_clock_->NowTicks() - start_time_; return tick_clock_->NowTicks() - start_time_;
UMA_HISTOGRAM_TIMES("Compositing.SurfaceDependencyDeadline.Duration",
duration);
return duration;
} }
bool SurfaceDependencyDeadline::operator==( bool SurfaceDependencyDeadline::operator==(
......
...@@ -13,7 +13,6 @@ ...@@ -13,7 +13,6 @@
#include "base/containers/adapters.h" #include "base/containers/adapters.h"
#include "base/containers/queue.h" #include "base/containers/queue.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/metrics/histogram_macros.h"
#include "base/threading/sequenced_task_runner_handle.h" #include "base/threading/sequenced_task_runner_handle.h"
#include "base/time/default_tick_clock.h" #include "base/time/default_tick_clock.h"
#include "components/viz/common/surfaces/parent_local_surface_id_allocator.h" #include "components/viz/common/surfaces/parent_local_surface_id_allocator.h"
...@@ -30,8 +29,6 @@ ...@@ -30,8 +29,6 @@
namespace viz { namespace viz {
namespace { namespace {
const char kUmaAliveSurfaces[] = "Compositing.SurfaceManager.AliveSurfaces";
constexpr base::TimeDelta kExpireInterval = base::TimeDelta::FromSeconds(10); constexpr base::TimeDelta kExpireInterval = base::TimeDelta::FromSeconds(10);
} // namespace } // namespace
...@@ -185,11 +182,6 @@ void SurfaceManager::GarbageCollectSurfaces() { ...@@ -185,11 +182,6 @@ void SurfaceManager::GarbageCollectSurfaces() {
} }
SurfaceIdSet reachable_surfaces = GetLiveSurfaces(); SurfaceIdSet reachable_surfaces = GetLiveSurfaces();
// Log the number of reachable surfaces after a garbage collection.
UMA_HISTOGRAM_CUSTOM_COUNTS(kUmaAliveSurfaces, reachable_surfaces.size(), 1,
200, 50);
std::vector<SurfaceId> surfaces_to_delete; std::vector<SurfaceId> surfaces_to_delete;
// Delete all destroyed and unreachable surfaces. // Delete all destroyed and unreachable surfaces.
......
...@@ -587,6 +587,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -587,6 +587,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Compositing.SurfaceDependencyDeadline.Duration" units="ms" <histogram name="Compositing.SurfaceDependencyDeadline.Duration" units="ms"
expires_after="2020-12-01"> expires_after="2020-12-01">
<obsolete>
Expired October 2020.
</obsolete>
<owner>jonross@chromium.org</owner> <owner>jonross@chromium.org</owner>
<owner>kylechar@chromium.org</owner> <owner>kylechar@chromium.org</owner>
<summary> <summary>
...@@ -598,6 +601,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -598,6 +601,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Compositing.SurfaceManager.AliveSurfaces" units="surfaces" <histogram name="Compositing.SurfaceManager.AliveSurfaces" units="surfaces"
expires_after="2020-12-01"> expires_after="2020-12-01">
<obsolete>
Expired October 2020.
</obsolete>
<owner>jonross@chromium.org</owner> <owner>jonross@chromium.org</owner>
<owner>kylechar@chromium.org</owner> <owner>kylechar@chromium.org</owner>
<summary> <summary>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment