Commit 0f93d88e authored by Donn Denman's avatar Donn Denman Committed by Commit Bot

[TTS] Fix the parameterized tests to enable/disable 2 features.

The previous CL that parameterized tests did not actually test
both the enabled and disabled states.

Also set the state of two different features: longpress and
translations.

BUG=956277, 952401

Change-Id: Iaac96c7baf2bc676be7e36877c906bc36fa6fc49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148822
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Reviewed-by: default avatarJinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766476}
parent 6b6e870d
...@@ -26,6 +26,7 @@ import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelManager; ...@@ -26,6 +26,7 @@ import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelManager;
import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelManagerWrapper; import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelManagerWrapper;
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel; import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel;
import org.chromium.chrome.browser.compositor.layouts.LayoutUpdateHost; import org.chromium.chrome.browser.compositor.layouts.LayoutUpdateHost;
import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.chrome.browser.flags.ChromeSwitches; import org.chromium.chrome.browser.flags.ChromeSwitches;
import org.chromium.chrome.test.ChromeActivityTestRule; import org.chromium.chrome.test.ChromeActivityTestRule;
import org.chromium.chrome.test.ChromeJUnit4ClassRunner; import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
...@@ -47,6 +48,11 @@ import org.chromium.ui.touch_selection.SelectionEventType; ...@@ -47,6 +48,11 @@ import org.chromium.ui.touch_selection.SelectionEventType;
*/ */
@RunWith(ChromeJUnit4ClassRunner.class) @RunWith(ChromeJUnit4ClassRunner.class)
@CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE}) @CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE})
// TODO(donnd): Add parameterized testing so Long-press resolve and Translations
// can be tested too. Or just remove this whole suite if it's not useful for
// these experimental triggering changes.
@Features.DisableFeatures({ChromeFeatureList.CONTEXTUAL_SEARCH_LONGPRESS_RESOLVE,
ChromeFeatureList.CONTEXTUAL_SEARCH_TRANSLATIONS})
public class ContextualSearchTapEventTest { public class ContextualSearchTapEventTest {
@Rule @Rule
public ChromeActivityTestRule<ChromeActivity> mActivityTestRule = public ChromeActivityTestRule<ChromeActivity> mActivityTestRule =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment