Commit 0fb84a2d authored by thakis@chromium.org's avatar thakis@chromium.org

Rip out code for logging cross-frame property accesses.

This depends on RenderView overriding a method of WebFrameClient
that was added in http://trac.webkit.org/changeset/56829 but
subsequently removed in http://trac.webkit.org/changeset/56849 .

Since the code has been nonfunctional for over 1 year, I figure it's
safe to remove it.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7645015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96742 0039d316-1c4b-4281-b951-d872f2087c98
parent c1d5377d
...@@ -771,19 +771,6 @@ void PageLoadHistograms::FrameWillClose(WebFrame* frame) { ...@@ -771,19 +771,6 @@ void PageLoadHistograms::FrameWillClose(WebFrame* frame) {
Dump(frame); Dump(frame);
} }
void PageLoadHistograms::LogCrossFramePropertyAccess(
WebFrame* frame,
WebFrame* target,
bool cross_origin,
const WebString& property_name,
unsigned long long event_id) {
// TODO(johnnyg): track the individual properties and repeat event_ids.
if (cross_origin)
cross_origin_access_count_++;
else
same_origin_access_count_++;
}
bool PageLoadHistograms::OnMessageReceived(const IPC::Message& message) { bool PageLoadHistograms::OnMessageReceived(const IPC::Message& message) {
if (message.type() == ViewMsg_ClosePage::ID) { if (message.type() == ViewMsg_ClosePage::ID) {
// TODO(davemoore) This code should be removed once willClose() gets // TODO(davemoore) This code should be removed once willClose() gets
......
...@@ -19,12 +19,6 @@ class PageLoadHistograms : public RenderViewObserver { ...@@ -19,12 +19,6 @@ class PageLoadHistograms : public RenderViewObserver {
private: private:
// RenderViewObserver implementation. // RenderViewObserver implementation.
virtual void FrameWillClose(WebKit::WebFrame* frame); virtual void FrameWillClose(WebKit::WebFrame* frame);
virtual void LogCrossFramePropertyAccess(
WebKit::WebFrame* frame,
WebKit::WebFrame* target,
bool cross_origin,
const WebKit::WebString& property_name,
unsigned long long event_id);
virtual bool OnMessageReceived(const IPC::Message& message); virtual bool OnMessageReceived(const IPC::Message& message);
// Dump all page load histograms appropriate for the given frame. // Dump all page load histograms appropriate for the given frame.
......
...@@ -2843,18 +2843,6 @@ void RenderView::didCreateIsolatedScriptContext(WebFrame* frame) { ...@@ -2843,18 +2843,6 @@ void RenderView::didCreateIsolatedScriptContext(WebFrame* frame) {
frame); frame);
} }
void RenderView::logCrossFramePropertyAccess(WebFrame* frame,
WebFrame* target,
bool cross_origin,
const WebString& property_name,
unsigned long long event_id) {
FOR_EACH_OBSERVER(
RenderViewObserver,
observers_,
LogCrossFramePropertyAccess(
frame, target, cross_origin, property_name, event_id));
}
void RenderView::didUpdateLayout(WebFrame* frame) { void RenderView::didUpdateLayout(WebFrame* frame) {
// We don't always want to set up a timer, only if we've been put in that // We don't always want to set up a timer, only if we've been put in that
// mode by getting a |ViewMsg_EnablePreferredSizeChangedMode| // mode by getting a |ViewMsg_EnablePreferredSizeChangedMode|
......
...@@ -551,12 +551,6 @@ class RenderView : public RenderWidget, ...@@ -551,12 +551,6 @@ class RenderView : public RenderWidget,
virtual void didCreateScriptContext(WebKit::WebFrame* frame); virtual void didCreateScriptContext(WebKit::WebFrame* frame);
virtual void didDestroyScriptContext(WebKit::WebFrame* frame); virtual void didDestroyScriptContext(WebKit::WebFrame* frame);
virtual void didCreateIsolatedScriptContext(WebKit::WebFrame* frame); virtual void didCreateIsolatedScriptContext(WebKit::WebFrame* frame);
virtual void logCrossFramePropertyAccess(
WebKit::WebFrame* frame,
WebKit::WebFrame* target,
bool cross_origin,
const WebKit::WebString& property_name,
unsigned long long event_id);
virtual void didUpdateLayout(WebKit::WebFrame* frame); virtual void didUpdateLayout(WebKit::WebFrame* frame);
virtual void didChangeScrollOffset(WebKit::WebFrame* frame); virtual void didChangeScrollOffset(WebKit::WebFrame* frame);
virtual void numberOfWheelEventHandlersChanged(unsigned num_handlers); virtual void numberOfWheelEventHandlersChanged(unsigned num_handlers);
......
...@@ -62,12 +62,6 @@ class RenderViewObserver : public IPC::Channel::Listener, ...@@ -62,12 +62,6 @@ class RenderViewObserver : public IPC::Channel::Listener,
virtual void DidCreateDataSource(WebKit::WebFrame* frame, virtual void DidCreateDataSource(WebKit::WebFrame* frame,
WebKit::WebDataSource* ds) {} WebKit::WebDataSource* ds) {}
virtual void PrintPage(WebKit::WebFrame* frame) {} virtual void PrintPage(WebKit::WebFrame* frame) {}
virtual void LogCrossFramePropertyAccess(
WebKit::WebFrame* frame,
WebKit::WebFrame* target,
bool cross_origin,
const WebKit::WebString& property_name,
unsigned long long event_id) {}
virtual void FocusedNodeChanged(const WebKit::WebNode& node) {} virtual void FocusedNodeChanged(const WebKit::WebNode& node) {}
// These match the RenderView methods. // These match the RenderView methods.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment