Commit 0fcd4a60 authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Cleanup] Use WebContentsConsoleObserver in //chrome/browser/extensions

Update chrome/browser/extensions/process_manager_browsertest.cc to
use WebContentsConsoleObserver instead of ConsoleObserverDelegate.
This allows us to observe console messages added without overriding
the existing delegate of the WebContents.

Bug: 1034150
Change-Id: I887ead0ef81b5ea8b76dbf0696c48882a2fb48cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327146Reviewed-by: default avatarDavid Bertoni <dbertoni@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792978}
parent ff49ab3c
...@@ -1130,9 +1130,8 @@ IN_PROC_BROWSER_TEST_F(ProcessManagerBrowserTest, ...@@ -1130,9 +1130,8 @@ IN_PROC_BROWSER_TEST_F(ProcessManagerBrowserTest,
OpenPopup(main_frame, GURL(url::kAboutBlankURL)); OpenPopup(main_frame, GURL(url::kAboutBlankURL));
EXPECT_NE(popup, tab); EXPECT_NE(popup, tab);
content::ConsoleObserverDelegate console_observer( content::WebContentsConsoleObserver console_observer(popup);
popup, "Not allowed to navigate top frame to*"); console_observer.SetPattern("Not allowed to navigate top frame to*");
popup->SetDelegate(&console_observer);
EXPECT_TRUE(ExecuteScript( EXPECT_TRUE(ExecuteScript(
popup, "location.href = '" + nested_urls[1].spec() + "';")); popup, "location.href = '" + nested_urls[1].spec() + "';"));
console_observer.Wait(); console_observer.Wait();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment