Commit 0fd68c17 authored by Erik Chen's avatar Erik Chen Committed by Commit Bot

Allow Lacros to be enabled on Stable channel via Finch config.

This CL does not currently change any configuration. Lacros is still
disabled by default on stable channel.

Bug: 1144323
Change-Id: I99354aa334931c8688d3eb46ef9e6bca1431efb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518753
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824185}
parent 364e9fdd
...@@ -8,6 +8,7 @@ ...@@ -8,6 +8,7 @@
#include "base/callback.h" #include "base/callback.h"
#include "base/containers/flat_map.h" #include "base/containers/flat_map.h"
#include "base/feature_list.h"
#include "base/files/file_path.h" #include "base/files/file_path.h"
#include "base/path_service.h" #include "base/path_service.h"
#include "base/process/process_handle.h" #include "base/process/process_handle.h"
...@@ -40,6 +41,10 @@ namespace crosapi { ...@@ -40,6 +41,10 @@ namespace crosapi {
namespace browser_util { namespace browser_util {
namespace { namespace {
// When this feature is enabled, Lacros will be available on stable channel.
const base::Feature kLacrosAllowOnStableChannel{
"LacrosAllowOnStableChannel", base::FEATURE_DISABLED_BY_DEFAULT};
// Some account types require features that aren't yet supported by lacros. // Some account types require features that aren't yet supported by lacros.
// See https://crbug.com/1080693 // See https://crbug.com/1080693
bool IsUserTypeAllowed(const User* user) { bool IsUserTypeAllowed(const User* user) {
...@@ -131,7 +136,7 @@ bool IsLacrosAllowed(Channel channel) { ...@@ -131,7 +136,7 @@ bool IsLacrosAllowed(Channel channel) {
// Developer builds can use lacros. // Developer builds can use lacros.
return true; return true;
case Channel::STABLE: case Channel::STABLE:
return false; return base::FeatureList::IsEnabled(kLacrosAllowOnStableChannel);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment