Commit 0ffd8cd3 authored by Jan Wilken Dörrie's avatar Jan Wilken Dörrie Committed by Commit Bot

[Settings WebUI] Fix Simultaneous Diplay of Password

This change fixes a UI bug where a hidden password was not correctly
updated when both the <password-list-item> and <password-edit-dialog>
were setting the same password at the same time.

Bug: 910081
Change-Id: If1ac5298ceebe1f12003083d87a85d1fa66a1f71
Reviewed-on: https://chromium-review.googlesource.com/c/1354275Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612787}
parent 7fab23cf
...@@ -374,7 +374,12 @@ Polymer({ ...@@ -374,7 +374,12 @@ Polymer({
showPassword_: function(event) { showPassword_: function(event) {
this.passwordManager_.getPlaintextPassword( this.passwordManager_.getPlaintextPassword(
/** @type {!number} */ (event.detail.item.entry.id), item => { /** @type {!number} */ (event.detail.item.entry.id), item => {
event.detail.set('item.password', item.plaintextPassword); // Note: We are explicitly not using event.detail.set() here, as that
// would not trigger notifyPath if event.detail.item.password is
// already equal to item.plaintextPassword. See crbug/910081 for more
// details.
event.detail.item.password = item.plaintextPassword;
event.detail.notifyPath('item.password');
}); });
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment