Commit 10531819 authored by Nico Weber's avatar Nico Weber

clang/win: Make dump_file_system.cc build.

In clang/win/gn builds, this file warned:
../../storage/browser/fileapi/dump_file_system.cc(96,71) : error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Werror,-Wreserved-user-defined-literal]
      ShowMessageAndExit(base::StringPrintf("GetFileInfo failed for %"PRId64,
                                                                      ^

In gyp builds, nothing in build/all.gyp depends on this target, and in non-Win
gn src/BUILD.gn blacklists this target.  So this warning is only seen on
clang/win gn builds.

No behavior change.

BUG=491209
TBR=tzik

Review URL: https://codereview.chromium.org/1303063010 .

Cr-Commit-Position: refs/heads/master@{#346781}
parent 0ae8dccc
...@@ -93,7 +93,7 @@ static void DumpDirectoryTree(const std::string& origin_name, ...@@ -93,7 +93,7 @@ static void DumpDirectoryTree(const std::string& origin_name,
SandboxDirectoryDatabase::FileInfo info; SandboxDirectoryDatabase::FileInfo info;
if (!directory_db.GetFileInfo(id, &info)) { if (!directory_db.GetFileInfo(id, &info)) {
ShowMessageAndExit(base::StringPrintf("GetFileInfo failed for %"PRId64, ShowMessageAndExit(base::StringPrintf("GetFileInfo failed for %" PRId64,
id)); id));
} }
...@@ -103,7 +103,7 @@ static void DumpDirectoryTree(const std::string& origin_name, ...@@ -103,7 +103,7 @@ static void DumpDirectoryTree(const std::string& origin_name,
if (info.is_directory()) { if (info.is_directory()) {
if (!directory_db.ListChildren(id, &children)) { if (!directory_db.ListChildren(id, &children)) {
ShowMessageAndExit(base::StringPrintf( ShowMessageAndExit(base::StringPrintf(
"ListChildren failed for %s (%"PRId64")", "ListChildren failed for %s (%" PRId64 ")",
info.name.c_str(), id)); info.name.c_str(), id));
} }
...@@ -122,7 +122,7 @@ static void DumpDirectoryTree(const std::string& origin_name, ...@@ -122,7 +122,7 @@ static void DumpDirectoryTree(const std::string& origin_name,
base::GetFileSize(origin_dir.Append(info.data_path), &size); base::GetFileSize(origin_dir.Append(info.data_path), &size);
} }
// TODO(hamaji): Modification time? // TODO(hamaji): Modification time?
printf("%s%s %"PRId64" %"PRId64" %s\n", printf("%s%s %" PRId64 " %" PRId64 " %s\n",
display_name, display_name,
directory_suffix, directory_suffix,
id, id,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment