Commit 1071919b authored by vmpstr's avatar vmpstr Committed by Commit bot

cc: Make discardable image metadata generation work with no caching.

This patch ensures that we can generate discardable images metadata
whether we have picture caching enabled or we don't.

BUG=543208
R=pdr
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1397203003

Cr-Commit-Position: refs/heads/master@{#354124}
parent dcd10462
...@@ -272,9 +272,9 @@ void DisplayItemList::EmitTraceSnapshot() const { ...@@ -272,9 +272,9 @@ void DisplayItemList::EmitTraceSnapshot() const {
void DisplayItemList::GenerateDiscardableImagesMetadata() { void DisplayItemList::GenerateDiscardableImagesMetadata() {
DCHECK(ProcessAppendedItemsCalled()); DCHECK(ProcessAppendedItemsCalled());
// This should be only called once, and only after CreateAndCacheSkPicture. // This should be only called once, and only after CreateAndCacheSkPicture.
DCHECK(picture_);
DCHECK(image_map_.empty()); DCHECK(image_map_.empty());
if (!picture_->willPlayBackBitmaps()) DCHECK_IMPLIES(use_cached_picture_, picture_);
if (use_cached_picture_ && !picture_->willPlayBackBitmaps())
return; return;
// The cached picture is translated by -layer_rect_.origin during record, // The cached picture is translated by -layer_rect_.origin during record,
...@@ -282,8 +282,8 @@ void DisplayItemList::GenerateDiscardableImagesMetadata() { ...@@ -282,8 +282,8 @@ void DisplayItemList::GenerateDiscardableImagesMetadata() {
// images. // images.
DiscardableImageMap::ScopedMetadataGenerator generator( DiscardableImageMap::ScopedMetadataGenerator generator(
&image_map_, gfx::Size(layer_rect_.right(), layer_rect_.bottom())); &image_map_, gfx::Size(layer_rect_.right(), layer_rect_.bottom()));
generator.canvas()->translate(layer_rect_.x(), layer_rect_.y()); Raster(generator.canvas(), nullptr,
generator.canvas()->drawPicture(picture_.get()); gfx::Rect(layer_rect_.right(), layer_rect_.bottom()), 1.f);
} }
void DisplayItemList::GetDiscardableImagesInRect( void DisplayItemList::GetDiscardableImagesInRect(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment